[PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-25 Thread Jani Nikula
On Mon, 25 Mar 2013, Dylan Semler wrote: > On Mon, Mar 25, 2013 at 9:41 AM, Jani Nikula > wrote: >> >> >> Hi, please find some review comments inline. >> > > You make some good points, thanks. > >> On Sat, 23 Mar 2013, Dylan Semler wrote: >> > >> > +/* Add an explicit mode based on a quirk >> >

[PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-25 Thread Jani Nikula
Hi, please find some review comments inline. BR, Jani. On Sat, 23 Mar 2013, Dylan Semler wrote: > There is at least one monitor that doesn't report its native resolution > in its EDID block. This enhancement extends the EDID quirk logic to > make monitors like this "just work". > > This patch

[PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-25 Thread Dylan Semler
On Mon, Mar 25, 2013 at 9:41 AM, Jani Nikula wrote: > > > Hi, please find some review comments inline. > You make some good points, thanks. > On Sat, 23 Mar 2013, Dylan Semler wrote: > > > > +/* Add an explicit mode based on a quirk > > + */ > > +static int > > +do_force_quirk_modes(struct drm_

Re: [PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-25 Thread Jani Nikula
On Mon, 25 Mar 2013, Dylan Semler wrote: > On Mon, Mar 25, 2013 at 9:41 AM, Jani Nikula > wrote: >> >> >> Hi, please find some review comments inline. >> > > You make some good points, thanks. > >> On Sat, 23 Mar 2013, Dylan Semler wrote: >> > >> > +/* Add an explicit mode based on a quirk >> >

Re: [PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-25 Thread Dylan Semler
On Mon, Mar 25, 2013 at 9:41 AM, Jani Nikula wrote: > > > Hi, please find some review comments inline. > You make some good points, thanks. > On Sat, 23 Mar 2013, Dylan Semler wrote: > > > > +/* Add an explicit mode based on a quirk > > + */ > > +static int > > +do_force_quirk_modes(struct drm_

Re: [PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-25 Thread Jani Nikula
Hi, please find some review comments inline. BR, Jani. On Sat, 23 Mar 2013, Dylan Semler wrote: > There is at least one monitor that doesn't report its native resolution > in its EDID block. This enhancement extends the EDID quirk logic to > make monitors like this "just work". > > This patch

[PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-22 Thread Dylan Semler
There is at least one monitor that doesn't report its native resolution in its EDID block. This enhancement extends the EDID quirk logic to make monitors like this "just work". This patch sets up a new quirk list where monitors' correct width, height, refresh rate, and reduced blanking parameters

[PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set a mode

2013-03-22 Thread Dylan Semler
There is at least one monitor that doesn't report its native resolution in its EDID block. This enhancement extends the EDID quirk logic to make monitors like this "just work". This patch sets up a new quirk list where monitors' correct width, height, refresh rate, and reduced blanking parameters