On Wed, Mar 6, 2019 at 4:18 AM Eric Anholt wrote:
>
> Rob Herring writes:
>
> > On Fri, Mar 1, 2019 at 11:23 PM Qiang Yu wrote:
> >>
> >> > > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe
> >> > > *pipe)
> >> > > +{
> >> > > + struct lima_fence *fence;
> >> > > +
>
Rob Herring writes:
> On Fri, Mar 1, 2019 at 11:23 PM Qiang Yu wrote:
>>
>> > > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe
>> > > *pipe)
>> > > +{
>> > > + struct lima_fence *fence;
>> > > +
>> > > + fence = kmem_cache_zalloc(lima_fence_slab, GFP_KERNEL);
On Fri, Mar 1, 2019 at 11:23 PM Qiang Yu wrote:
>
> > > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe *pipe)
> > > +{
> > > + struct lima_fence *fence;
> > > +
> > > + fence = kmem_cache_zalloc(lima_fence_slab, GFP_KERNEL);
> >
> > Out of curiosity, what is the
On Tue, Mar 5, 2019 at 1:20 AM Rob Herring wrote:
>
> On Sat, Mar 2, 2019 at 12:23 PM Rob Clark wrote:
> >
> > On Fri, Mar 1, 2019 at 9:32 PM Qiang Yu wrote:
> > >
> > > On Thu, Feb 28, 2019 at 5:41 AM Rob Herring wrote:
> > > >
> > > > On Wed, Feb 27, 2019 at 7:42 AM Qiang Yu wrote:
> > > >
On Sat, Mar 2, 2019 at 12:23 PM Rob Clark wrote:
>
> On Fri, Mar 1, 2019 at 9:32 PM Qiang Yu wrote:
> >
> > On Thu, Feb 28, 2019 at 5:41 AM Rob Herring wrote:
> > >
> > > On Wed, Feb 27, 2019 at 7:42 AM Qiang Yu wrote:
> > > > diff --git a/drivers/gpu/drm/lima/lima_drv.c
> > > >
On Fri, Mar 1, 2019 at 9:32 PM Qiang Yu wrote:
>
> On Thu, Feb 28, 2019 at 5:41 AM Rob Herring wrote:
> >
> > On Wed, Feb 27, 2019 at 7:42 AM Qiang Yu wrote:
> > > diff --git a/drivers/gpu/drm/lima/lima_drv.c
> > > b/drivers/gpu/drm/lima/lima_drv.c> > > new file mode 100644
> > > index
> > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe *pipe)
> > +{
> > + struct lima_fence *fence;
> > +
> > + fence = kmem_cache_zalloc(lima_fence_slab, GFP_KERNEL);
>
> Out of curiosity, what is the benefit of using a separate slab here?
> If this is beneficial,
Hi Qiang.
Two general comments:
- We are trying to avoid drmP.h in new drivers, please drop
- The use of idr is being replaced with XArray, see patch-set
posted by Matthew Wilcox.
Try to use XArray so we do not introduce a new user.
This was from a very quick looks at the driver.
In general
