Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 12:44:19PM +0100, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 12:21:28PM +0100, Daniel Vetter wrote: > > On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote: > > > On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > > > > > > > I definitely do

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 12:21:28PM +0100, Daniel Vetter wrote: > On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote: > > On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > > > > > I definitely don't want that we don't attempt this. But brought from > > > > years > > >

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Thierry Reding
On Mon, Feb 06, 2017 at 11:11:27PM +0100, Noralf Trønnes wrote: > > Den 06.02.2017 16.53, skrev Daniel Vetter: > > On Mon, Feb 06, 2017 at 12:08:47PM +0100, Thierry Reding wrote: > > > On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 6, 2017 at 10:35 AM, Thierry R

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > > > I definitely don't want that we don't attempt this. But brought from years > > > of experience, I recommend to merge first (with pre-refactoring already > > > a

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-07 Thread Thierry Reding
On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > I definitely don't want that we don't attempt this. But brought from years > > of experience, I recommend to merge first (with pre-refactoring already > > applied, but helpers only extracted, not yet at the right spot), and then >

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Daniel Vetter
On Mon, Feb 06, 2017 at 04:55:55PM -0600, Rob Herring wrote: > On Mon, Feb 6, 2017 at 5:08 AM, Thierry Reding > wrote: > > On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: > >> On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding > >> wrote: > >> > >> > > > > +EXPORT_SYMBOL(tinydrm_disa

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote: > > > > I definitely don't want that we don't attempt this. But brought from years > > of experience, I recommend to merge first (with pre-refactoring already > > applied, but helpers only extracted, not yet at the right spot), and then >

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Rob Herring
On Mon, Feb 6, 2017 at 5:08 AM, Thierry Reding wrote: > On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: >> On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding >> wrote: >> >> > > > > +EXPORT_SYMBOL(tinydrm_disable_backlight); >> > > > > +#endif >> > > > >> > > > These look like they re

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Dave Airlie
> > I definitely don't want that we don't attempt this. But brought from years > of experience, I recommend to merge first (with pre-refactoring already > applied, but helpers only extracted, not yet at the right spot), and then > follow up with. Because on average, there's way too many trees with

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Noralf Trønnes
Den 06.02.2017 16.53, skrev Daniel Vetter: On Mon, Feb 06, 2017 at 12:08:47PM +0100, Thierry Reding wrote: On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding wrote: +EXPORT_SYMBOL(tinydrm_disable_backlight); +#endif These look lik

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Daniel Vetter
On Mon, Feb 06, 2017 at 12:08:47PM +0100, Thierry Reding wrote: > On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: > > On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding > > wrote: > > > > > > > > +EXPORT_SYMBOL(tinydrm_disable_backlight); > > > > > > +#endif > > > > > > > > > > These

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Thierry Reding
On Mon, Feb 06, 2017 at 11:07:42AM +0100, Daniel Vetter wrote: > On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding > wrote: > > > > > > +EXPORT_SYMBOL(tinydrm_disable_backlight); > > > > > +#endif > > > > > > > > These look like they really should be part of the backlight subsystem. > > I > > > > d

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Jani Nikula
On Tue, 31 Jan 2017, Noralf Trønnes wrote: > +#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE BACKLIGHT_CLASS_DEVICE is a tristate, you'll want #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) and probably either depends on BACKLIGHT_CLASS_DEVICE or depends on BACKLIGHT_CLASS_DEVICE || BAC

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Daniel Vetter
On Mon, Feb 6, 2017 at 10:35 AM, Thierry Reding wrote: > > > > +EXPORT_SYMBOL(tinydrm_disable_backlight); > > > > +#endif > > > > > > These look like they really should be part of the backlight subsystem. > I > > > don't see anything DRM specific about them. Well, except for the error > > > messa

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Thierry Reding
On Mon, Feb 06, 2017 at 10:09:18AM +0100, Daniel Vetter wrote: > On Mon, Feb 06, 2017 at 09:56:29AM +0100, Thierry Reding wrote: > > On Tue, Jan 31, 2017 at 05:03:14PM +0100, Noralf Trønnes wrote: [...] > > > +/** > > > + * tinydrm_merge_clips - Merge clip rectangles > > > + * @dst: Destination cli

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Daniel Vetter
On Mon, Feb 06, 2017 at 09:56:29AM +0100, Thierry Reding wrote: > On Tue, Jan 31, 2017 at 05:03:14PM +0100, Noralf Trønnes wrote: > > Add common functionality needed by many tinydrm drivers. > > > > Signed-off-by: Noralf Trønnes > > Acked-by: Daniel Vetter > > --- > > Documentation/gpu/tinydrm.

Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-02-06 Thread Thierry Reding
On Tue, Jan 31, 2017 at 05:03:14PM +0100, Noralf Trønnes wrote: > Add common functionality needed by many tinydrm drivers. > > Signed-off-by: Noralf Trønnes > Acked-by: Daniel Vetter > --- > Documentation/gpu/tinydrm.rst | 9 + > drivers/gpu/drm/tinydrm/core/Makefile

[PATCH v3 2/7] drm/tinydrm: Add helper functions

2017-01-31 Thread Noralf Trønnes
Add common functionality needed by many tinydrm drivers. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/tinydrm.rst | 9 + drivers/gpu/drm/tinydrm/core/Makefile | 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 462 ++