Re: [PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

2024-03-27 Thread Steven Price
On 26/03/2024 11:12, Boris Brezillon wrote: > There's no reason for _irq_suspend/resume() to be called after the > device has been unplugged, and keeping this dev_enter/exit() > section in _irq_suspend() is turns _irq_suspend() into a NOP > when called from the _unplug() functions, which we don't

Re: [PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

2024-03-26 Thread Liviu Dudau
On Tue, Mar 26, 2024 at 12:12:05PM +0100, Boris Brezillon wrote: > There's no reason for _irq_suspend/resume() to be called after the > device has been unplugged, and keeping this dev_enter/exit() > section in _irq_suspend() is turns _irq_suspend() into a NOP > when called from the _unplug()

Re: [PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

2024-03-26 Thread Boris Brezillon
On Tue, 26 Mar 2024 12:12:05 +0100 Boris Brezillon wrote: > There's no reason for _irq_suspend/resume() to be called after the > device has been unplugged, and keeping this dev_enter/exit() > section in _irq_suspend() is turns _irq_suspend() into a NOP ^ s/is

[PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

2024-03-26 Thread Boris Brezillon
There's no reason for _irq_suspend/resume() to be called after the device has been unplugged, and keeping this dev_enter/exit() section in _irq_suspend() is turns _irq_suspend() into a NOP when called from the _unplug() functions, which we don't want. v3: - New patch Fixes: 5fe909cae118