Re: [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 8/29/19 9:08 AM, Peter Rosin wrote: > On 2019-08-27 13:35, Geert Uytterhoeven wrote: >> Hi Peter, >> >> On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin wrote: >>> The variable is only ever used from fbcon.c which is linked into the >>> same module. Therefore, the export is not needed. >>> >>> Sig

Re: [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo

2019-08-29 Thread Peter Rosin
On 2019-08-27 13:35, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin wrote: >> The variable is only ever used from fbcon.c which is linked into the >> same module. Therefore, the export is not needed. >> >> Signed-off-by: Peter Rosin > > Reviewed-by: Geert

Re: [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo

2019-08-27 Thread Geert Uytterhoeven
Hi Peter, On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin wrote: > The variable is only ever used from fbcon.c which is linked into the > same module. Therefore, the export is not needed. > > Signed-off-by: Peter Rosin Reviewed-by: Geert Uytterhoeven But note that the same is true for fb_class, s

[PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo

2019-08-27 Thread Peter Rosin
The variable is only ever used from fbcon.c which is linked into the same module. Therefore, the export is not needed. Signed-off-by: Peter Rosin --- drivers/video/fbdev/core/fbmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fb