Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-11-27 Thread Brian Norris
(Dropping Mark, whose Rockchip address is dead; and fixing Chris's email again) On Mon, Nov 27, 2017 at 4:29 PM, Brian Norris wrote: > On Thu, Oct 26, 2017 at 09:44:14AM +, Philippe CORNU wrote: >> On 10/26/2017 06:13 AM, Archit Taneja wrote: >> > On 10/26/2017 06:39 AM, Brian Norris wrote: >

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-11-27 Thread Brian Norris
On Thu, Oct 26, 2017 at 09:44:14AM +, Philippe CORNU wrote: > On 10/26/2017 06:13 AM, Archit Taneja wrote: > > On 10/26/2017 06:39 AM, Brian Norris wrote: > >> somebody already working on refactoring existing Rockchip code to use > >> this? > > > > I don't know. If rockchip isn't interested in

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-26 Thread Brian Norris
(correction zyw's email ".comg" is not a TLD!) Hi, On Thu, Oct 26, 2017 at 09:44:14AM +, Philippe CORNU wrote: > On 10/26/2017 06:13 AM, Archit Taneja wrote: > > On 10/26/2017 06:39 AM, Brian Norris wrote: > >> On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote: > >>> Archit asked a qu

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-26 Thread Philippe CORNU
Hi, On 10/26/2017 06:13 AM, Archit Taneja wrote: > Hi, > > On 10/26/2017 06:39 AM, Brian Norris wrote: >> On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote: >>> Archit asked a question about moving to >>> dw-mipi-dsi >> >> That question made me think though: this approach seems backwards.

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-25 Thread Archit Taneja
Hi, On 10/26/2017 06:39 AM, Brian Norris wrote: On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote: Archit asked a question about moving to dw-mipi-dsi That question made me think though: this approach seems backwards. It seems like someone did copy/paste/fork, and then we're asking th

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-25 Thread Brian Norris
On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote: > Archit asked a question about moving to > dw-mipi-dsi That question made me think though: this approach seems backwards. It seems like someone did copy/paste/fork, and then we're asking the authors of the original driver to un-fork? It s

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-25 Thread Sean Paul
On Wed, Oct 25, 2017 at 11:51:00AM +0800, Nickey Yang wrote: > This patch correct Feedback divider setting: > 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN > 2、Due to the use of a "by 2 pre-scaler," the range of the > feedback multiplication Feedback divider is limited to even > division number

[PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-24 Thread Nickey Yang
This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider must be greater than 12, less than 1000. 3、Make