Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-27 Thread Manuel Traut
Hi Jonas, On Wed, Jan 03, 2024 at 03:19:25PM +0100, Jonas Karlman wrote: > Hi Manuel, > > On 2024-01-03 14:40, Manuel Traut wrote: > > Hi Jonas and Ondřej, > > > + { > +pinctrl-names = "default"; > +pinctrl-0 = <_dual_io_pins>; > +status = "okay"; >

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-26 Thread Manuel Traut
Hello Ondřej, On Fri, Jan 05, 2024 at 05:48:46PM +0100, Ondřej Jirman wrote: > On Fri, Jan 05, 2024 at 05:11:03PM +0100, Manuel Traut wrote: > > On Wed, Jan 03, 2024 at 10:42:54AM +0100, Ondřej Jirman wrote: > > > Hello Manuel, > > > > > > a few more things I noticed: > > > > > > On Tue, Jan

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-05 Thread Ondřej Jirman
On Fri, Jan 05, 2024 at 05:11:03PM +0100, Manuel Traut wrote: > On Wed, Jan 03, 2024 at 10:42:54AM +0100, Ondřej Jirman wrote: > > Hello Manuel, > > > > a few more things I noticed: > > > > On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > > > From: Alexander Warnecke > > > > > >

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-05 Thread Manuel Traut
Hi Jonas, On Wed, Jan 03, 2024 at 03:19:25PM +0100, Jonas Karlman wrote: > Hi Manuel, > > On 2024-01-03 14:40, Manuel Traut wrote: > > Hi Jonas and Ondřej, > > > + { > +pinctrl-names = "default"; > +pinctrl-0 = <_dual_io_pins>; > +status = "okay"; >

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-05 Thread Manuel Traut
On Wed, Jan 03, 2024 at 10:42:54AM +0100, Ondřej Jirman wrote: > Hello Manuel, > > a few more things I noticed: > > On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > > From: Alexander Warnecke > > > > + leds { > > + compatible = "gpio-leds"; > > + > > +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-03 Thread Jonas Karlman
Hi Manuel, On 2024-01-03 14:40, Manuel Traut wrote: > Hi Jonas and Ondřej, > + { + pinctrl-names = "default"; + pinctrl-0 = <_dual_io_pins>; + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible =

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-03 Thread Manuel Traut
Hi Jonas and Ondřej, > >> + { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <_dual_io_pins>; > >> + status = "okay"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + flash@0 { > >> + compatible = "jedec,spi-nor"; > >> + reg = <0>; > >> +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-03 Thread Manuel Traut
On Tue, Jan 02, 2024 at 07:07:56PM +0100, Ondřej Jirman wrote: > Hello Manuel, Hello Ondřej, > On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > > From: Alexander Warnecke > > > > [...] > > > > + > > + backlight: backlight { > > + compatible = "pwm-backlight"; > > +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-03 Thread Ondřej Jirman
Hello Manuel, a few more things I noticed: On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > From: Alexander Warnecke > > + leds { > + compatible = "gpio-leds"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <_led_en_h>; > + > +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-02 Thread Dang Huynh
On Tuesday, January 2, 2024 6:07:56 PM UTC Ondřej Jirman wrote: > On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > > + { > > + pinctrl-names = "default"; > > + pinctrl-0 = <_reset_h>; > > + reset-gpios = < RK_PB2 GPIO_ACTIVE_HIGH>; > > + vpcie3v3-supply = <_minipcie>; > > +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-02 Thread Ondřej Jirman
On Tue, Jan 02, 2024 at 09:56:20PM +0100, Jonas Karlman wrote: > Hi Manuel and Ondřej, > > On 2024-01-02 19:07, Ondřej Jirman wrote: > > Hello Manuel, > > [...] > > >> + > >> + { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <_dual_io_pins>; > >> + status = "okay"; > >> +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-02 Thread Jonas Karlman
Hi Manuel and Ondřej, On 2024-01-02 19:07, Ondřej Jirman wrote: > Hello Manuel, [...] >> + >> + { >> +pinctrl-names = "default"; >> +pinctrl-0 = <_dual_io_pins>; >> +status = "okay"; >> +#address-cells = <1>; >> +#size-cells = <0>; >> + >> +flash@0 { >> +

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-02 Thread Ondřej Jirman
Hello Manuel, see below... On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > From: Alexander Warnecke > > [...] > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi > b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi > new file mode 100644 > index

[PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-01-02 Thread Manuel Traut
From: Alexander Warnecke This includes support for both the v0.1 units that were sent to developers and the v2.0 units from production. v1.0 is not included as no units are known to exist. Working/Tested: - SDMMC - UART - Buttons - Charging/Battery/PMIC - Audio - USB - Display Signed-off-by: