Re: [PATCH v3 5/5] drm/msm/dsi: Remove incorrect references to slice_count

2023-05-22 Thread Jessica Zhang
On 5/20/2023 5:32 PM, Dmitry Baryshkov wrote: On 20/05/2023 00:17, Jessica Zhang wrote: Currently, slice_count is being used to calculate word count and pkt_per_line. In downstream, these values are calculated using slice per packet, which is not the same as slice_count. I'd say the

Re: [PATCH v3 5/5] drm/msm/dsi: Remove incorrect references to slice_count

2023-05-20 Thread Dmitry Baryshkov
On 20/05/2023 00:17, Jessica Zhang wrote: Currently, slice_count is being used to calculate word count and pkt_per_line. In downstream, these values are calculated using slice per packet, which is not the same as slice_count. I'd say the reference to downstream is not correct. We have seen

Re: [PATCH v3 5/5] drm/msm/dsi: Remove incorrect references to slice_count

2023-05-19 Thread Jessica Zhang
On 5/19/2023 2:24 PM, Marijn Suijten wrote: On 2023-05-19 14:17:30, Jessica Zhang wrote: Currently, slice_count is being used to calculate word count and pkt_per_line. In downstream, these values are calculated using slice per packet, which is not the same as slice_count. Slice count

Re: [PATCH v3 5/5] drm/msm/dsi: Remove incorrect references to slice_count

2023-05-19 Thread Marijn Suijten
On 2023-05-19 14:17:30, Jessica Zhang wrote: > Currently, slice_count is being used to calculate word count and > pkt_per_line. In downstream, these values are calculated using slice per > packet, which is not the same as slice_count. > > Slice count represents the number of soft slices per

[PATCH v3 5/5] drm/msm/dsi: Remove incorrect references to slice_count

2023-05-19 Thread Jessica Zhang
Currently, slice_count is being used to calculate word count and pkt_per_line. In downstream, these values are calculated using slice per packet, which is not the same as slice_count. Slice count represents the number of soft slices per interface, and its value will not always match that of slice