Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-03-05 Thread Robin Murphy
On 19/02/2019 10:55, Maxime Ripard wrote: Hi Robin, On Wed, Feb 13, 2019 at 04:40:11PM +, Robin Murphy wrote: On 13/02/2019 15:41, Maxime Ripard wrote: Hi Robin, Thanks for your feedback! On Tue, Feb 12, 2019 at 06:46:40PM +, Robin Murphy wrote: On 11/02/2019 15:02, Maxime Ripard

Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-19 Thread Maxime Ripard
Hi Robin, On Wed, Feb 13, 2019 at 04:40:11PM +, Robin Murphy wrote: > On 13/02/2019 15:41, Maxime Ripard wrote: > > Hi Robin, > > > > Thanks for your feedback! > > > > On Tue, Feb 12, 2019 at 06:46:40PM +, Robin Murphy wrote: > > > On 11/02/2019 15:02, Maxime Ripard wrote: > > > > Now

Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-13 Thread Robin Murphy
On 13/02/2019 15:41, Maxime Ripard wrote: Hi Robin, Thanks for your feedback! On Tue, Feb 12, 2019 at 06:46:40PM +, Robin Murphy wrote: On 11/02/2019 15:02, Maxime Ripard wrote: Now that we can express our DMA topology, rely on those property instead of hardcoding an offset from the

Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-13 Thread Maxime Ripard
Hi Robin, Thanks for your feedback! On Tue, Feb 12, 2019 at 06:46:40PM +, Robin Murphy wrote: > On 11/02/2019 15:02, Maxime Ripard wrote: > > Now that we can express our DMA topology, rely on those property instead of > > hardcoding an offset from the dma_addr_t which wasn't really great. >

Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-12 Thread Robin Murphy
On 11/02/2019 15:02, Maxime Ripard wrote: Now that we can express our DMA topology, rely on those property instead of hardcoding an offset from the dma_addr_t which wasn't really great. We still need to add some code to deal with the old DT that would lack that property, but we move the offset

[PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-11 Thread Maxime Ripard
Now that we can express our DMA topology, rely on those property instead of hardcoding an offset from the dma_addr_t which wasn't really great. We still need to add some code to deal with the old DT that would lack that property, but we move the offset to the DRM device dma_pfn_offset to be able