Re: [RESEND PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-10-29 Thread Paul Cercueil
Series applied, thanks! Cheers, -Paul Le ven., oct. 29 2021 at 18:55:50 +0200, Christophe Branchereau a écrit : Reviewed-by: Christophe Branchereau On Tue, Oct 26, 2021 at 8:13 PM Paul Cercueil wrote: Attach a top-level bridge to each encoder, which will be used for negociating the b

Re: [RESEND PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-10-29 Thread Christophe Branchereau
Reviewed-by: Christophe Branchereau On Tue, Oct 26, 2021 at 8:13 PM Paul Cercueil wrote: > > Attach a top-level bridge to each encoder, which will be used for > negociating the bus format and flags. > > All the bridges are now attached with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Paul

[RESEND PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-10-26 Thread Paul Cercueil
Attach a top-level bridge to each encoder, which will be used for negociating the bus format and flags. All the bridges are now attached with DRM_BRIDGE_ATTACH_NO_CONNECTOR. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 92 +-- 1 file changed,

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-27 Thread H. Nikolaus Schaller
Hi Paul, > Am 25.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Le sam., sept. 25 2021 at 21:26:42 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 25.09.2021 um 21:08 schrieb Paul Cercueil : >>> Hi Paul & Nikolaus, >>> If you spent some time debugging the issue >> we did ... > >

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-25 Thread Paul Cercueil
Le sam., sept. 25 2021 at 21:26:42 +0200, H. Nikolaus Schaller a écrit : Hi Paul, Am 25.09.2021 um 21:08 schrieb Paul Cercueil : Hi Paul & Nikolaus, If you spent some time debugging the issue we did ... By saying that you didn't debug, I mean that you did not try to see why you h

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-25 Thread H. Nikolaus Schaller
Hi Paul, > Am 25.09.2021 um 21:08 schrieb Paul Cercueil : > > Hi Paul & Nikolaus, > > If you spent some time debugging the issue we did ... > instead of complaining that my patchset breaks things... ... we did have a working version (without hdmi-connector) and bisect pointed at your patch...

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-25 Thread Paul Cercueil
Hi Paul & Nikolaus, If you spent some time debugging the issue instead of complaining that my patchset breaks things... The fix is a one-liner in your downstream ingenic-dw-hdmi.c: .output_port = 1 in the ingenic_dw_hdmi_plat_data struct. Absolutely nothing else needs to be changed for HDMI t

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-25 Thread Paul Boddie
On Friday, 24 September 2021 10:29:02 CEST Paul Cercueil wrote: > > Le ven., sept. 24 2021 at 00:51:39 +0200, Paul Boddie > > > > 2. My approach, which just involves changing the Synopsys driver to > > set the bridge type in dw_hdmi_probe like this: > > > > hdmi->bridge.type = DRM_MODE_CONNECTOR

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-24 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 22:23 schrieb H. Nikolaus Schaller : > > >> Because your "it doesn't work" arguments have zero weight otherwise. > > I hope I still can find it. So I can't promise anything. > We have had it complete in DTS and added code to parse it. > It may have been wiped out by

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-24 Thread Paul Cercueil
Hi Paul, Le ven., sept. 24 2021 at 00:51:39 +0200, Paul Boddie a écrit : On Thursday, 23 September 2021 22:23:28 CEST H. Nikolaus Schaller wrote: > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > Start by wiring things properly, like in my previously linked DTS, and > *test*. If i

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Boddie
On Thursday, 23 September 2021 22:23:28 CEST H. Nikolaus Schaller wrote: > > > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Start by wiring things properly, like in my previously linked DTS, and > > *test*. If it fails, tell us where it fails. > > Well, I tell where drm_bridge_attach fa

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Le jeu., sept. 23 2021 at 20:52:23 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 23.09.2021 um 15:30 schrieb Paul Cercueil : >>> Hi Nikolaus, >>> Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller >>>

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Cercueil
Le jeu., sept. 23 2021 at 20:52:23 +0200, H. Nikolaus Schaller a écrit : Hi Paul, Am 23.09.2021 um 15:30 schrieb Paul Cercueil : Hi Nikolaus, Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller a écrit : Hi Laurent, Ah, ok. But then we still have issues. Firstly I wo

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H . Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 15:30 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller > a écrit : >> Hi Laurent, >> Ah, ok. >> But then we still have issues. >> Firstly I would assume that get_edid only works properly if it is initialized

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Cercueil
Hi Nikolaus, Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller a écrit : Hi Laurent, Am 23.09.2021 um 12:03 schrieb Laurent Pinchart : Hi Nikolaus, On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: Am 23.09.2021 um 11:27 schrieb Laurent Pinchart: On

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > IMHO it is leaving (mature) dw-hdmi untouched and make attachment of a > connector > in ingenic_drm_bind() depend on some condition. Since I don't know details of the DRM bridge/encoder/connector APIs), let me reformulate the quersion for a condition specifically. How can one

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > Am 23.09.2021 um 12:03 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: >>> Am 23.09.2021 um 11:27 schrieb Laurent Pinchart: >>> On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: >

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Laurent Pinchart
Hi Nikolaus, On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: > > Am 23.09.2021 um 11:27 schrieb Laurent Pinchart: > > On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: > >> > > + ret = drm_bridge_attach(encoder, &ib->bridge, NULL, >

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > Am 23.09.2021 um 11:27 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: >> > + ret = drm_bridge_attach(encoder, &ib->bridge, NULL, > + DRM_BRIDGE_ATTACH_NO_CONNE

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Laurent Pinchart
Hi Nikolaus, On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: > > Am 23.09.2021 um 10:49 schrieb Paul Cercueil: > > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller a écrit : > >> Hi Paul, > >> thanks for another update. > >> We have been delayed to rework the CI

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Laurent Pinchart
Hello, On Thu, Sep 23, 2021 at 09:49:03AM +0100, Paul Cercueil wrote: > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller a écrit : > > Hi Paul, > > thanks for another update. > > > > We have been delayed to rework the CI20 HDMI code on top of your series > > but it basically works i

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 10:49 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >> thanks for another update. >> We have been delayed to rework the CI20 HDMI code on top of your series >> but it basically wor

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Cercueil
Hi Nikolaus, Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller a écrit : Hi Paul, thanks for another update. We have been delayed to rework the CI20 HDMI code on top of your series but it basically works in some situations. There is for example a problem if the EDID reports DRM

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-22 Thread H. Nikolaus Schaller
Hi Paul, thanks for another update. We have been delayed to rework the CI20 HDMI code on top of your series but it basically works in some situations. There is for example a problem if the EDID reports DRM_COLOR_FORMAT_YCRCB422 but it appears to be outside of your series. The only issue we have i

[PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-22 Thread Paul Cercueil
Attach a top-level bridge to each encoder, which will be used for negociating the bus format and flags. All the bridges are now attached with DRM_BRIDGE_ATTACH_NO_CONNECTOR. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 92 +-- 1 file changed,