Re: [PATCH v3 6/6] drm/shmem-helper: Switch to reservation lock

2023-05-29 Thread Dmitry Osipenko
On 5/22/23 16:02, Emil Velikov wrote: >> -void drm_gem_shmem_put_pages(struct drm_gem_shmem_object *shmem) >> +static int drm_gem_shmem_pin_locked(struct drm_gem_shmem_object *shmem) >> +{ >> + int ret; >> + >> + dma_resv_assert_held(shmem->base.resv); >> + >> + ret = drm_gem_shme

Re: [PATCH v3 6/6] drm/shmem-helper: Switch to reservation lock

2023-05-22 Thread Dmitry Osipenko
On 5/22/23 16:02, Emil Velikov wrote: > Hi Dmitry, > > Saw v3 fly by, so I had a quick look. Original RB still stands, > although I noticed a couple of non-blocking nitpicks. > > On Sun, 21 May 2023 at 22:00, Dmitry Osipenko > wrote: > >> -static int drm_gem_shmem_get_pages_locked(struct drm_ge

Re: [PATCH v3 6/6] drm/shmem-helper: Switch to reservation lock

2023-05-22 Thread Emil Velikov
Hi Dmitry, Saw v3 fly by, so I had a quick look. Original RB still stands, although I noticed a couple of non-blocking nitpicks. On Sun, 21 May 2023 at 22:00, Dmitry Osipenko wrote: > -static int drm_gem_shmem_get_pages_locked(struct drm_gem_shmem_object *shmem) > +static int drm_gem_shmem_get_

[PATCH v3 6/6] drm/shmem-helper: Switch to reservation lock

2023-05-21 Thread Dmitry Osipenko
Replace all drm-shmem locks with a GEM reservation lock. This makes locks consistent with dma-buf locking convention where importers are responsible for holding reservation lock for all operations performed over dma-bufs, preventing deadlock between dma-buf importers and exporters. Suggested-by: D