Re: (subset) [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-28 Thread Lee Jones
On Fri, 21 Jul 2023 09:29:03 +, Ying Liu wrote: > So, let's drop output GPIO direction check and only check GPIO value to set > the initial power state. > > Applied, thanks! [1/1] backlight: gpio_backlight: Drop output GPIO direction check for initial power state commit:

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-24 Thread Linus Walleij
On Fri, Jul 21, 2023 at 11:29 AM Ying Liu wrote: > If GPIO pin is in input state but backlight is currently off due to > default pull downs, Oh what an interesting corner case! > then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread Bartosz Golaszewski
On Fri, Jul 21, 2023 at 11:29 AM Ying Liu wrote: > > If GPIO pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread a...@kernel.org
On Fri, Jul 21, 2023 at 09:29:03AM +, Ying Liu wrote: > If GPIO pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in

[PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread Ying Liu
If GPIO pin is in input state but backlight is currently off due to default pull downs, then initial power state is set to FB_BLANK_UNBLANK in DT boot mode with phandle link and the backlight is effectively turned on in gpio_backlight_probe(), which is undesirable according to patch description of