Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-06 Thread Daniel Vetter
On Thu, 31 Mar 2022 at 22:41, Ville Syrjälä wrote: > > On Thu, Mar 31, 2022 at 10:25:23PM +0200, Daniel Vetter wrote: > > On Thu, Mar 31, 2022 at 11:11:00PM +0300, Ville Syrjälä wrote: > > > On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote: > > > > On Thu, Mar 31, 2022 at 10:52:54PM +

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Ville Syrjälä
On Thu, Mar 31, 2022 at 10:25:23PM +0200, Daniel Vetter wrote: > On Thu, Mar 31, 2022 at 11:11:00PM +0300, Ville Syrjälä wrote: > > On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote: > > > On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote: > > > > On Thu, Mar 31, 2022 at 09:

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Daniel Vetter
On Thu, Mar 31, 2022 at 11:11:00PM +0300, Ville Syrjälä wrote: > On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote: > > On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote: > > > On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote: > > > > On Thu, Mar 31, 2022 at 06:

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Ville Syrjälä
On Thu, Mar 31, 2022 at 10:02:53PM +0200, Daniel Vetter wrote: > On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote: > > On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote: > > > On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote: > > > > On Thu, Mar 31, 2022 at 05:

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Daniel Vetter
On Thu, Mar 31, 2022 at 10:52:54PM +0300, Ville Syrjälä wrote: > On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote: > > On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote: > > > On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote: > > > > On Thu, Mar 31, 2022 at 04:

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Ville Syrjälä
On Thu, Mar 31, 2022 at 09:11:29PM +0200, Daniel Vetter wrote: > On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote: > > On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote: > > > On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote: > > > > On Thu, Mar 31, 2022 at 03:

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Daniel Vetter
On Thu, Mar 31, 2022 at 06:48:43PM +0300, Ville Syrjälä wrote: > On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote: > > On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote: > > > On Thu, Mar 31, 2022 at 03:05:45PM +0200, Maxime Ripard wrote: > > > > From: Daniel Vetter > > >

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Ville Syrjälä
On Thu, Mar 31, 2022 at 05:14:29PM +0200, Daniel Vetter wrote: > On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote: > > On Thu, Mar 31, 2022 at 03:05:45PM +0200, Maxime Ripard wrote: > > > From: Daniel Vetter > > > > > > The stuff never really worked, and leads to lots of fun because

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Daniel Vetter
On Thu, Mar 31, 2022 at 04:25:13PM +0300, Ville Syrjälä wrote: > On Thu, Mar 31, 2022 at 03:05:45PM +0200, Maxime Ripard wrote: > > From: Daniel Vetter > > > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other

Re: [PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Ville Syrjälä
On Thu, Mar 31, 2022 at 03:05:45PM +0200, Maxime Ripard wrote: > From: Daniel Vetter > > The stuff never really worked, and leads to lots of fun because it > out-of-order frees atomic states. Which upsets KASAN, among other > things. > > For async updates we now have a more solid solution with t

[PATCH v4] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-03-31 Thread Maxime Ripard
From: Daniel Vetter The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async_commit hooks. Support for that for