Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: [...] > > Acked-by: Maxime Ripard > Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Thu, Sep 14, 2023 at 03:23:53PM +0200, Javier Martinez Canillas wrote: >> Maxime Ripard writes: >> >> Hello Maxime, >> >> > Hi, >> > >> > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: >> >> static const struct drm_crtc_helper_funcs

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Maxime Ripard
On Thu, Sep 14, 2023 at 03:23:53PM +0200, Javier Martinez Canillas wrote: > Maxime Ripard writes: > > Hello Maxime, > > > Hi, > > > > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: > >> static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { > >>

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > Hi, > > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: >> static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { >> .mode_valid = ssd130x_crtc_helper_mode_valid, >> -.atomic_check =

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Maxime Ripard
Hi, On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: > static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { > .mode_valid = ssd130x_crtc_helper_mode_valid, > - .atomic_check = drm_crtc_helper_atomic_check, > + .atomic_check =

[PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-12 Thread Javier Martinez Canillas
The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") moved the allocation of the intermediate and HW buffers from the encoder's .atomic_enable callback, to the plane's .atomic_check callback. This was suggested by Maxime Ripard, because drivers aren't