Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-09 Thread Dennis Dalessandro
On 7/6/21 1:59 PM, Jason Gunthorpe wrote: > I can not say the same about other company's RDMA driver > distributions, Daniel's description of "minimal effort to get > goodwill" would match others much better. Not sure what other RDMA driver you are talking about but as for Cornelis Networks, we

Re: [Linaro-mm-sig] [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-07 Thread Daniel Vetter
On Wed, Jul 7, 2021 at 2:17 PM Christian König wrote: > Am 06.07.21 um 14:23 schrieb Daniel Vetter: > > On Tue, Jul 06, 2021 at 02:21:10PM +0200, Christoph Hellwig wrote: > >> On Tue, Jul 06, 2021 at 10:40:37AM +0200, Daniel Vetter wrote: > Greg, I hope this will be good enough for you to

Re: [Linaro-mm-sig] [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-07 Thread Christian König
Am 06.07.21 um 14:23 schrieb Daniel Vetter: On Tue, Jul 06, 2021 at 02:21:10PM +0200, Christoph Hellwig wrote: On Tue, Jul 06, 2021 at 10:40:37AM +0200, Daniel Vetter wrote: Greg, I hope this will be good enough for you to merge this code. So we're officially going to use dri-devel for

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Alex Deucher
On Tue, Jul 6, 2021 at 2:31 PM Jason Gunthorpe wrote: > > On Tue, Jul 06, 2021 at 07:35:55PM +0200, Daniel Vetter wrote: > > > Yup. We dont care about any of the fancy pieces you build on top, nor > > does the compiler need to be the optimizing one. Just something that's > > good enough to drive

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 8:31 PM Jason Gunthorpe wrote: > On Tue, Jul 06, 2021 at 07:35:55PM +0200, Daniel Vetter wrote: > > Yup. We dont care about any of the fancy pieces you build on top, nor > > does the compiler need to be the optimizing one. Just something that's > > good enough to drive the

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 07:35:55PM +0200, Daniel Vetter wrote: > Yup. We dont care about any of the fancy pieces you build on top, nor > does the compiler need to be the optimizing one. Just something that's > good enough to drive the hw in some demons to see how it works and all > that.

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
I should stop typing and prep dinner, but I found some too hilarious typos below. On Tue, Jul 6, 2021 at 7:35 PM Daniel Vetter wrote: > > On Tue, Jul 6, 2021 at 6:29 PM Jason Gunthorpe wrote: > > > > On Tue, Jul 06, 2021 at 05:49:01PM +0200, Daniel Vetter wrote: > > > > > The other thing to

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 07:31:37PM +0200, Christoph Hellwig wrote: > On Tue, Jul 06, 2021 at 02:28:28PM -0300, Jason Gunthorpe wrote: > > > Also on your claim that drivers/gpu is a non-upstream disaster: I've > > > also learned that that for drivers/rdma there's the upstream driver, > > > and then

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 6:29 PM Jason Gunthorpe wrote: > > On Tue, Jul 06, 2021 at 05:49:01PM +0200, Daniel Vetter wrote: > > > The other thing to keep in mind is that one of these drivers supports > > 25 years of product generations, and the other one doesn't. > > Sure, but that is the point,

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 06:07:17PM +0200, Daniel Vetter wrote: > Also on your claim that drivers/gpu is a non-upstream disaster: I've > also learned that that for drivers/rdma there's the upstream driver, > and then there's the out-of-tree hackjob the vendor actually > supports. In the

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 05:49:01PM +0200, Daniel Vetter wrote: > The other thing to keep in mind is that one of these drivers supports > 25 years of product generations, and the other one doesn't. Sure, but that is the point, isn't it? To have an actually useful thing you need all of this mess

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 5:49 PM Daniel Vetter wrote: > On Tue, Jul 6, 2021 at 5:25 PM Jason Gunthorpe wrote: > > I'm not sure about this all or nothing approach. AFAIK DRM has the > > worst problems with out of tree drivers right now. > > Well I guess someone could stand up a

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 4:56 PM Jason Gunthorpe wrote: > On Tue, Jul 06, 2021 at 04:09:25PM +0200, Daniel Vetter wrote: > > Anyway, for anything that works like a gpu accelerator, like 3d accel, > > or parallel compute accel (aka gpgpu) or spatial compute accel (aka > > NN/AI) or maybe even fpga

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 5:25 PM Jason Gunthorpe wrote: > On Tue, Jul 06, 2021 at 04:39:19PM +0200, Daniel Vetter wrote: > > On Tue, Jul 6, 2021 at 4:23 PM Jason Gunthorpe wrote: > > > > > > On Tue, Jul 06, 2021 at 12:36:51PM +0200, Daniel Vetter wrote: > > > > > > > If that means AI companies

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 04:39:19PM +0200, Daniel Vetter wrote: > On Tue, Jul 6, 2021 at 4:23 PM Jason Gunthorpe wrote: > > > > On Tue, Jul 06, 2021 at 12:36:51PM +0200, Daniel Vetter wrote: > > > > > If that means AI companies don't want to open our their hw specs > > > enough to allow that, so

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 04:09:25PM +0200, Daniel Vetter wrote: > Anyway, for anything that works like a gpu accelerator, like 3d accel, > or parallel compute accel (aka gpgpu) or spatial compute accel (aka > NN/AI) or maybe even fpga accel most of the magic to use the hardware > is in this backend

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 4:23 PM Jason Gunthorpe wrote: > > On Tue, Jul 06, 2021 at 12:36:51PM +0200, Daniel Vetter wrote: > > > If that means AI companies don't want to open our their hw specs > > enough to allow that, so be it - all you get in that case is > > offloading the kernel side of the

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 12:36:51PM +0200, Daniel Vetter wrote: > If that means AI companies don't want to open our their hw specs > enough to allow that, so be it - all you get in that case is > offloading the kernel side of the stack for convenience, with zero > long term prospects to ever make

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 3:44 PM Jason Gunthorpe wrote: > > On Tue, Jul 06, 2021 at 02:07:16PM +0200, Daniel Vetter wrote: > > > On the "rdma-core" idea, afaik rdma NIC do not have fully programmable > > cores in their hw, for which you'd need some kind of compiler to make > > use of the hardware

Re: [Linaro-mm-sig] [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Oded Gabbay
On Tue, Jul 6, 2021 at 4:17 PM Daniel Vetter wrote: > > On Tue, Jul 6, 2021 at 2:46 PM Oded Gabbay wrote: > > > > On Tue, Jul 6, 2021 at 3:23 PM Daniel Vetter wrote: > > > > > > On Tue, Jul 06, 2021 at 02:21:10PM +0200, Christoph Hellwig wrote: > > > > On Tue, Jul 06, 2021 at 10:40:37AM +0200,

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Jason Gunthorpe
On Tue, Jul 06, 2021 at 02:07:16PM +0200, Daniel Vetter wrote: > On the "rdma-core" idea, afaik rdma NIC do not have fully programmable > cores in their hw, for which you'd need some kind of compiler to make > use of the hardware and the interfaces the kernel provides? So not > really

Re: [Linaro-mm-sig] [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 2:46 PM Oded Gabbay wrote: > > On Tue, Jul 6, 2021 at 3:23 PM Daniel Vetter wrote: > > > > On Tue, Jul 06, 2021 at 02:21:10PM +0200, Christoph Hellwig wrote: > > > On Tue, Jul 06, 2021 at 10:40:37AM +0200, Daniel Vetter wrote: > > > > > Greg, I hope this will be good

Re: [Linaro-mm-sig] [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Oded Gabbay
On Tue, Jul 6, 2021 at 3:23 PM Daniel Vetter wrote: > > On Tue, Jul 06, 2021 at 02:21:10PM +0200, Christoph Hellwig wrote: > > On Tue, Jul 06, 2021 at 10:40:37AM +0200, Daniel Vetter wrote: > > > > Greg, I hope this will be good enough for you to merge this code. > > > > > > So we're officially

Re: [Linaro-mm-sig] [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 06, 2021 at 02:21:10PM +0200, Christoph Hellwig wrote: > On Tue, Jul 06, 2021 at 10:40:37AM +0200, Daniel Vetter wrote: > > > Greg, I hope this will be good enough for you to merge this code. > > > > So we're officially going to use dri-devel for technical details review > > and then

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 12:47 PM Daniel Vetter wrote: > On Tue, Jul 6, 2021 at 12:36 PM Daniel Vetter wrote: > > On Tue, Jul 6, 2021 at 12:03 PM Oded Gabbay wrote: > > > > > > On Tue, Jul 6, 2021 at 11:40 AM Daniel Vetter wrote: > > > > > > > > On Mon, Jul 05, 2021 at 04:03:12PM +0300, Oded

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 12:36 PM Daniel Vetter wrote: > On Tue, Jul 6, 2021 at 12:03 PM Oded Gabbay wrote: > > > > On Tue, Jul 6, 2021 at 11:40 AM Daniel Vetter wrote: > > > > > > On Mon, Jul 05, 2021 at 04:03:12PM +0300, Oded Gabbay wrote: > > > > Hi, > > > > I'm sending v4 of this patch-set

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Tue, Jul 6, 2021 at 12:03 PM Oded Gabbay wrote: > > On Tue, Jul 6, 2021 at 11:40 AM Daniel Vetter wrote: > > > > On Mon, Jul 05, 2021 at 04:03:12PM +0300, Oded Gabbay wrote: > > > Hi, > > > I'm sending v4 of this patch-set following the long email thread. > > > I want to thank Jason for

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Oded Gabbay
On Tue, Jul 6, 2021 at 11:40 AM Daniel Vetter wrote: > > On Mon, Jul 05, 2021 at 04:03:12PM +0300, Oded Gabbay wrote: > > Hi, > > I'm sending v4 of this patch-set following the long email thread. > > I want to thank Jason for reviewing v3 and pointing out the errors, saving > > us time later to

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-06 Thread Daniel Vetter
On Mon, Jul 05, 2021 at 04:03:12PM +0300, Oded Gabbay wrote: > Hi, > I'm sending v4 of this patch-set following the long email thread. > I want to thank Jason for reviewing v3 and pointing out the errors, saving > us time later to debug it :) > > I consulted with Christian on how to fix patch 2

[PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-05 Thread Oded Gabbay
Hi, I'm sending v4 of this patch-set following the long email thread. I want to thank Jason for reviewing v3 and pointing out the errors, saving us time later to debug it :) I consulted with Christian on how to fix patch 2 (the implementation) and at the end of the day I shamelessly copied the