Re: [PATCH v4 09/10] drm/sched: Add helper to queue TDR immediately for current and future jobs

2023-10-04 Thread Matthew Brost
On Fri, Sep 29, 2023 at 06:44:53PM -0400, Luben Tuikov wrote: > On 2023-09-19 01:01, Matthew Brost wrote: > > Add helper to queue TDR immediately for current and future jobs. This > > will be used in XE, new Intel GPU driver, to trigger the TDR to cleanup > > Please use present tense, "is", in cod

Re: [PATCH v4 09/10] drm/sched: Add helper to queue TDR immediately for current and future jobs

2023-09-29 Thread Luben Tuikov
On 2023-09-19 01:01, Matthew Brost wrote: > Add helper to queue TDR immediately for current and future jobs. This > will be used in XE, new Intel GPU driver, to trigger the TDR to cleanup Please use present tense, "is", in code, comments, commits, etc. Is it "XE" or is it "Xe"? I always thought i

[PATCH v4 09/10] drm/sched: Add helper to queue TDR immediately for current and future jobs

2023-09-18 Thread Matthew Brost
Add helper to queue TDR immediately for current and future jobs. This will be used in XE, new Intel GPU driver, to trigger the TDR to cleanup a drm_scheduler that encounter errors. v2: - Drop timeout args, rename function, use mod delayed work (Luben) Signed-off-by: Matthew Brost --- drivers/g