Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2019-10-22 Thread Daniel Vetter
On Fri, May 18, 2018 at 1:52 PM Andrzej Hajda wrote: > > On 26.04.2018 10:07, Jyri Sarha wrote: > > Add device_link from panel device (supplier) to drm device (consumer) > > when drm_panel_attach() is called. This patch should protect the > > master drm driver if an attached panel driver unbinds w

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-08-31 Thread Andrzej Hajda
On 31.08.2018 10:56, Linus Walleij wrote: > On Thu, Aug 30, 2018 at 4:41 PM Andrzej Hajda wrote: >> [Me] >>> This happens because the connector struct device is the >>> same as the bridge struct device, I suppose. >> I guess it is rather because the code tries to make circular dependency: >> 1. pa

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-08-31 Thread Linus Walleij
On Thu, Aug 30, 2018 at 4:41 PM Andrzej Hajda wrote: > [Me] > > This happens because the connector struct device is the > > same as the bridge struct device, I suppose. > > I guess it is rather because the code tries to make circular dependency: > 1. panel depends on dsi-host because it is MIPI-DS

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-08-30 Thread Andrzej Hajda
On 30.08.2018 14:32, Linus Walleij wrote: > On Thu, Apr 26, 2018 at 10:07 AM Jyri Sarha wrote: > >> Add device_link from panel device (supplier) to drm device (consumer) >> when drm_panel_attach() is called. This patch should protect the >> master drm driver if an attached panel driver unbinds whi

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-08-30 Thread Linus Walleij
On Thu, Apr 26, 2018 at 10:07 AM Jyri Sarha wrote: > Add device_link from panel device (supplier) to drm device (consumer) > when drm_panel_attach() is called. This patch should protect the > master drm driver if an attached panel driver unbinds while it is in > use. The device_link should make s

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-08-09 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 10:07 AM, Jyri Sarha wrote: > Add device_link from panel device (supplier) to drm device (consumer) > when drm_panel_attach() is called. This patch should protect the > master drm driver if an attached panel driver unbinds while it is in > use. The device_link should make s

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-24 Thread Peter Rosin
On 2018-05-23 14:38, Andrzej Hajda wrote: > On 23.05.2018 12:46, Peter Rosin wrote: >> On 2018-05-23 11:39, Andrzej Hajda wrote: >> >> *snip* >> >>> Panels are managed by dsi host only if dsi host implements it, and it is >>> up to dsi host author, it is not mandatory. The only case I am aware of >

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-24 Thread Peter Rosin
On 2018-05-22 17:03, Peter Rosin wrote: > On 2018-05-22 11:45, Andrzej Hajda wrote: >> On 22.05.2018 09:36, Peter Rosin wrote: >>> On 2018-05-22 08:29, Andrzej Hajda wrote: On 21.05.2018 23:56, Peter Rosin wrote: > On 2018-05-21 11:21, Andrzej Hajda wrote: >> On 21.05.2018 10:53, Peter

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-24 Thread Peter Rosin
On 2018-05-23 11:39, Andrzej Hajda wrote: *snip* > Panels are managed by dsi host only if dsi host implements it, and it is > up to dsi host author, it is not mandatory. The only case I am aware of > is exynos-dsi. I guess most developers are not aware of the problem, or > they do not care, or ..

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-23 Thread Andrzej Hajda
On 23.05.2018 12:46, Peter Rosin wrote: > On 2018-05-23 11:39, Andrzej Hajda wrote: > > *snip* > >> Panels are managed by dsi host only if dsi host implements it, and it is >> up to dsi host author, it is not mandatory. The only case I am aware of >> is exynos-dsi. I guess most developers are not a

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-23 Thread Andrzej Hajda
On 23.05.2018 10:29, Peter Rosin wrote: > On 2018-05-22 17:03, Peter Rosin wrote: >> On 2018-05-22 11:45, Andrzej Hajda wrote: >>> On 22.05.2018 09:36, Peter Rosin wrote: On 2018-05-22 08:29, Andrzej Hajda wrote: > On 21.05.2018 23:56, Peter Rosin wrote: >> On 2018-05-21 11:21, Andrzej

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-23 Thread Peter Rosin
On 2018-05-22 08:29, Andrzej Hajda wrote: > On 21.05.2018 23:56, Peter Rosin wrote: >> On 2018-05-21 11:21, Andrzej Hajda wrote: >>> On 21.05.2018 10:53, Peter Rosin wrote: On 2018-05-21 10:15, Andrzej Hajda wrote: > On 19.05.2018 18:48, Peter Rosin wrote: >> On 2018-05-18 13:51, Andrz

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-23 Thread Peter Rosin
On 2018-05-22 11:45, Andrzej Hajda wrote: > On 22.05.2018 09:36, Peter Rosin wrote: >> On 2018-05-22 08:29, Andrzej Hajda wrote: >>> On 21.05.2018 23:56, Peter Rosin wrote: On 2018-05-21 11:21, Andrzej Hajda wrote: > On 21.05.2018 10:53, Peter Rosin wrote: >> On 2018-05-21 10:15, Andrz

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-23 Thread Peter Rosin
On 2018-05-22 09:36, Peter Rosin wrote: > On 2018-05-22 08:29, Andrzej Hajda wrote: >> On 21.05.2018 23:56, Peter Rosin wrote: >>> On 2018-05-21 11:21, Andrzej Hajda wrote: On 21.05.2018 10:53, Peter Rosin wrote: > On 2018-05-21 10:15, Andrzej Hajda wrote: >> On 19.05.2018 18:48, Peter

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-22 Thread Andrzej Hajda
On 22.05.2018 09:36, Peter Rosin wrote: > On 2018-05-22 08:29, Andrzej Hajda wrote: >> On 21.05.2018 23:56, Peter Rosin wrote: >>> On 2018-05-21 11:21, Andrzej Hajda wrote: On 21.05.2018 10:53, Peter Rosin wrote: > On 2018-05-21 10:15, Andrzej Hajda wrote: >> On 19.05.2018 18:48, Peter

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-22 Thread Peter Rosin
On 2018-05-21 11:21, Andrzej Hajda wrote: > On 21.05.2018 10:53, Peter Rosin wrote: >> On 2018-05-21 10:15, Andrzej Hajda wrote: >>> On 19.05.2018 18:48, Peter Rosin wrote: On 2018-05-18 13:51, Andrzej Hajda wrote: > On 26.04.2018 10:07, Jyri Sarha wrote: >> Add device_link from panel

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-21 Thread Andrzej Hajda
On 21.05.2018 23:56, Peter Rosin wrote: > On 2018-05-21 11:21, Andrzej Hajda wrote: >> On 21.05.2018 10:53, Peter Rosin wrote: >>> On 2018-05-21 10:15, Andrzej Hajda wrote: On 19.05.2018 18:48, Peter Rosin wrote: > On 2018-05-18 13:51, Andrzej Hajda wrote: >> On 26.04.2018 10:07, Jyri

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-21 Thread Peter Rosin
On 2018-05-21 10:15, Andrzej Hajda wrote: > On 19.05.2018 18:48, Peter Rosin wrote: >> On 2018-05-18 13:51, Andrzej Hajda wrote: >>> On 26.04.2018 10:07, Jyri Sarha wrote: Add device_link from panel device (supplier) to drm device (consumer) when drm_panel_attach() is called. This patch s

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-21 Thread Andrzej Hajda
On 21.05.2018 10:53, Peter Rosin wrote: > On 2018-05-21 10:15, Andrzej Hajda wrote: >> On 19.05.2018 18:48, Peter Rosin wrote: >>> On 2018-05-18 13:51, Andrzej Hajda wrote: On 26.04.2018 10:07, Jyri Sarha wrote: > Add device_link from panel device (supplier) to drm device (consumer) >

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-21 Thread Peter Rosin
On 2018-05-18 13:51, Andrzej Hajda wrote: > On 26.04.2018 10:07, Jyri Sarha wrote: >> Add device_link from panel device (supplier) to drm device (consumer) >> when drm_panel_attach() is called. This patch should protect the >> master drm driver if an attached panel driver unbinds while it is in >>

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-21 Thread Peter Rosin
On 2018-05-19 18:48, Peter Rosin wrote: > On 2018-05-18 13:51, Andrzej Hajda wrote: >> On 26.04.2018 10:07, Jyri Sarha wrote: >>> Add device_link from panel device (supplier) to drm device (consumer) >>> when drm_panel_attach() is called. This patch should protect the >>> master drm driver if an at

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-21 Thread Andrzej Hajda
On 19.05.2018 18:48, Peter Rosin wrote: > On 2018-05-18 13:51, Andrzej Hajda wrote: >> On 26.04.2018 10:07, Jyri Sarha wrote: >>> Add device_link from panel device (supplier) to drm device (consumer) >>> when drm_panel_attach() is called. This patch should protect the >>> master drm driver if an at

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-18 Thread Jyri Sarha
On 18/05/18 14:51, Andrzej Hajda wrote: > On 26.04.2018 10:07, Jyri Sarha wrote: >> Add device_link from panel device (supplier) to drm device (consumer) >> when drm_panel_attach() is called. This patch should protect the >> master drm driver if an attached panel driver unbinds while it is in >> us

Re: [PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-05-18 Thread Andrzej Hajda
On 26.04.2018 10:07, Jyri Sarha wrote: > Add device_link from panel device (supplier) to drm device (consumer) > when drm_panel_attach() is called. This patch should protect the > master drm driver if an attached panel driver unbinds while it is in > use. The device_link should make sure the drm de

[PATCH v4 2/2] drm/panel: Add device_link from panel device to drm device

2018-04-26 Thread Jyri Sarha
Add device_link from panel device (supplier) to drm device (consumer) when drm_panel_attach() is called. This patch should protect the master drm driver if an attached panel driver unbinds while it is in use. The device_link should make sure the drm device is unbound before the panel driver becomes