Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-24 Thread Dan Carpenter
On Mon, Aug 24, 2020 at 02:27:08PM +0300, Dan Carpenter wrote: > On Mon, Aug 24, 2020 at 02:24:57PM +0300, Dan Carpenter wrote: > > On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > > > On 8/21/20 8:28 AM, Tomer Samara wrote: > > > > Remove BUG() from ion_sytem_heap.c > > > > > > >

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-24 Thread Dan Carpenter
On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > On 8/21/20 8:28 AM, Tomer Samara wrote: > > Remove BUG() from ion_sytem_heap.c > > > > this fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > recovery code ratherthan BUG() or BUG_ON(). > >

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-24 Thread Dan Carpenter
On Mon, Aug 24, 2020 at 02:24:57PM +0300, Dan Carpenter wrote: > On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > > On 8/21/20 8:28 AM, Tomer Samara wrote: > > > Remove BUG() from ion_sytem_heap.c > > > > > > this fix the following checkpatch issue: > > > Avoid crashing the kernel

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-24 Thread Randy Dunlap
On 8/22/20 2:34 AM, Tomer Samara wrote: > On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: >> On 8/21/20 8:28 AM, Tomer Samara wrote: >>> Remove BUG() from ion_sytem_heap.c >>> >>> this fix the following checkpatch issue: >>> Avoid crashing the kernel - try using WARN_ON & >>>

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-24 Thread Tomer Samara
On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > On 8/21/20 8:28 AM, Tomer Samara wrote: > > Remove BUG() from ion_sytem_heap.c > > > > this fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > recovery code ratherthan BUG() or BUG_ON(). > >

[PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-22 Thread Tomer Samara
Remove BUG() from ion_sytem_heap.c this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

2020-08-22 Thread Randy Dunlap
On 8/21/20 8:28 AM, Tomer Samara wrote: > Remove BUG() from ion_sytem_heap.c > > this fix the following checkpatch issue: > Avoid crashing the kernel - try using WARN_ON & > recovery code ratherthan BUG() or BUG_ON(). > > Signed-off-by: Tomer Samara > --- >