Re: [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen

2022-01-08 Thread Dmitry Torokhov
Hi Rajat, On Tue, Dec 21, 2021 at 04:11:26PM -0800, Rajat Jain wrote: > +static int chromeos_privacy_screen_remove(struct acpi_device *adev) > +{ > + struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev); Please add an empty line here: WARNING: Missing a blank line after

[PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen

2021-12-21 Thread Rajat Jain
This adds the ACPI driver for the ChromeOS privacy screen that is present on some chromeos devices. Note that ideally, we'd want this privacy screen driver to be probed BEFORE the drm probe in order to avoid a drm probe deferral: https://hansdegoede.livejournal.com/25948.html In practise, I