Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 10/10/2023 15:05, Thomas Zimmermann wrote: Hi Am 10.10.23 um 11:33 schrieb Maxime Ripard: [...] We also have discussions about kexec/kdump support. Here we'd need to retrieve the scanout address, forward it to the kexec kernel and put simpledrm onto that framebuffer until the regular driver

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 10/10/2023 14:59, Daniel Vetter wrote: On Tue, Oct 10, 2023 at 02:15:47PM +0200, Maxime Ripard wrote: On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: On 10/10/23 11:25, Maxime Ripard wrote: On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: So if I

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 10.10.23 um 14:59 schrieb Daniel Vetter: [...] Why can't we use the model[1] suggested by Daniel using a draw_pixel callback giving drivers full control on how they can put a pixel on the display? I share kind of the same general ideas/conclusions: "qthe idea is that all the fb

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 10.10.23 um 11:33 schrieb Maxime Ripard: [...] We also have discussions about kexec/kdump support. Here we'd need to retrieve the scanout address, forward it to the kexec kernel and put simpledrm onto that framebuffer until the regular driver takes over. Generically speaking, there's

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Daniel Vetter
On Tue, Oct 10, 2023 at 02:15:47PM +0200, Maxime Ripard wrote: > On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: > > > > > > On 10/10/23 11:25, Maxime Ripard wrote: > > > > > > > > > On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: > > So if I understand

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: > > > On 10/10/23 11:25, Maxime Ripard wrote: > > > > > > On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: > So if I understand correctly, drm_panic would pre-allocate a > plane/commit, > and use

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Noralf Trønnes
On 10/10/23 11:25, Maxime Ripard wrote: > > > On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: So if I understand correctly, drm_panic would pre-allocate a plane/commit, and use that when a panic occurs ? >>> >>> And have it checked already, yes. We would only wait

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 11:04:33AM +0200, Thomas Zimmermann wrote: > Am 09.10.23 um 18:07 schrieb Maxime Ripard: > > On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: > > > > > - I find it risky to completely reconfigure the hardware in a panic > > > > > handler. > > > > > > > > I

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: > > > So if I understand correctly, drm_panic would pre-allocate a plane/commit, > > > and use that when a panic occurs ? > > > > And have it checked already, yes. We would only wait for a panic to > > happen to pull the trigger

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 09.10.23 um 18:07 schrieb Maxime Ripard: On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: - I find it risky to completely reconfigure the hardware in a panic handler. I would expect to only change the format and base address of the framebuffer. I guess it can fail, but

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 09.10.23 um 13:33 schrieb Maxime Ripard: [...] And you don't need to support all kinds of tiling, YUV or RGB variants. We should indeed not use YUV at all. For RGB, we already have plenty of conversion code from XRGB-to-, so we are more flexible there. So if I understand

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 09:55:46AM +0200, Jocelyn Falempe wrote: > On 09/10/2023 18:07, Maxime Ripard wrote: > > On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: > > > > > - I find it risky to completely reconfigure the hardware in a panic > > > > > handler. > > > > > > > > I

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 09/10/2023 18:07, Maxime Ripard wrote: On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: - I find it risky to completely reconfigure the hardware in a panic handler. I would expect to only change the format and base address of the framebuffer. I guess it can fail, but it

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Maxime Ripard
On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: > > > - I find it risky to completely reconfigure the hardware in a panic > > > handler. > > > > I would expect to only change the format and base address of the > > framebuffer. I guess it can fail, but it doesn't seem that

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Jocelyn Falempe
On 09/10/2023 13:33, Maxime Ripard wrote: On Mon, Oct 09, 2023 at 11:48:29AM +0200, Jocelyn Falempe wrote: On 09/10/2023 10:28, Maxime Ripard wrote: Hi, On Mon, Oct 09, 2023 at 09:47:49AM +0200, Jocelyn Falempe wrote: On 06/10/2023 18:54, Noralf Trønnes wrote: On 10/6/23 16:35, Maxime

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Maxime Ripard
On Mon, Oct 09, 2023 at 11:48:29AM +0200, Jocelyn Falempe wrote: > On 09/10/2023 10:28, Maxime Ripard wrote: > > Hi, > > > > On Mon, Oct 09, 2023 at 09:47:49AM +0200, Jocelyn Falempe wrote: > > > On 06/10/2023 18:54, Noralf Trønnes wrote: > > > > > > > > > > > > On 10/6/23 16:35, Maxime Ripard

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Jocelyn Falempe
On 09/10/2023 10:28, Maxime Ripard wrote: Hi, On Mon, Oct 09, 2023 at 09:47:49AM +0200, Jocelyn Falempe wrote: On 06/10/2023 18:54, Noralf Trønnes wrote: On 10/6/23 16:35, Maxime Ripard wrote: Hi Jocelyn, On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: On 05/10/2023

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Maxime Ripard
Hi, On Mon, Oct 09, 2023 at 09:47:49AM +0200, Jocelyn Falempe wrote: > On 06/10/2023 18:54, Noralf Trønnes wrote: > > > > > > On 10/6/23 16:35, Maxime Ripard wrote: > > > Hi Jocelyn, > > > > > > On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: > > > > On 05/10/2023 10:18,

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Jocelyn Falempe
On 07/10/2023 14:38, Noralf Trønnes wrote: On 10/3/23 16:22, Jocelyn Falempe wrote: This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-09 Thread Jocelyn Falempe
On 06/10/2023 18:54, Noralf Trønnes wrote: On 10/6/23 16:35, Maxime Ripard wrote: Hi Jocelyn, On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: On 05/10/2023 10:18, Maxime Ripard wrote: Hi, On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: diff --git

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-07 Thread Noralf Trønnes
On 10/3/23 16:22, Jocelyn Falempe wrote: > This module displays a user friendly message when a kernel panic > occurs. It currently doesn't contain any debug information, > but that can be added later. > > v2 > * Use get_scanout_buffer() instead of the drm client API. > (Thomas Zimmermann) >

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-06 Thread Noralf Trønnes
On 10/6/23 16:35, Maxime Ripard wrote: > Hi Jocelyn, > > On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: >> On 05/10/2023 10:18, Maxime Ripard wrote: >>> Hi, >>> >>> On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: diff --git a/include/drm/drm_drv.h

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-06 Thread Maxime Ripard
Hi Jocelyn, On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote: > On 05/10/2023 10:18, Maxime Ripard wrote: > > Hi, > > > > On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: > > > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > > > index

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-05 Thread Jocelyn Falempe
On 05/10/2023 10:18, Maxime Ripard wrote: Hi, On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 89e2706cac56..e538c87116d3 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -43,6 +43,7 @@ struct

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-05 Thread Maxime Ripard
Hi, On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote: > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 89e2706cac56..e538c87116d3 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -43,6 +43,7 @@ struct dma_buf_attachment; > struct

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-04 Thread kernel test robot
: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c patch link: https://lore.kernel.org/r/20231003142508.190246-3-jfalempe%40redhat.com patch subject: [PATCH v4 2/4] drm/panic: Add a drm panic handler config: i386-randconfig-063-20231005 (https://download.01.org/0day-ci/archive/20231005/202310051128

[PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-03 Thread Jocelyn Falempe
This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis)