Re: [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Dmitry Osipenko
On 6/26/23 12:40, Boris Brezillon wrote: > I think here is the major problem I have with this patch: you've made > drm_gem_shmem_{get_pages,pin}() private, which forces me to call > drm_gem_shmem_pin() in a path where I already acquired the resv lock > (using the drm_exec infra proposed by Christia

Re: [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Dmitry Osipenko
On 6/26/23 12:40, Boris Brezillon wrote: > Same problem with this renaming: it's confusing because this function > was previously taking care of the locking, and it's no longer the case. > That's actually true for other public functions your patching, but I > won't go over all of them. > > I know

Re: [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Boris Brezillon
On Mon, 26 Jun 2023 11:40:14 +0200 Boris Brezillon wrote: > Hi Dmitry, > > On Tue, 30 May 2023 01:39:35 +0300 > Dmitry Osipenko wrote: > > > Replace all drm-shmem locks with a GEM reservation lock. This makes locks > > consistent with dma-buf locking convention where importers are responsible

Re: [PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-06-26 Thread Boris Brezillon
Hi Dmitry, On Tue, 30 May 2023 01:39:35 +0300 Dmitry Osipenko wrote: > Replace all drm-shmem locks with a GEM reservation lock. This makes locks > consistent with dma-buf locking convention where importers are responsible > for holding reservation lock for all operations performed over dma-bufs,

[PATCH v4 6/6] drm/shmem-helper: Switch to reservation lock

2023-05-29 Thread Dmitry Osipenko
Replace all drm-shmem locks with a GEM reservation lock. This makes locks consistent with dma-buf locking convention where importers are responsible for holding reservation lock for all operations performed over dma-bufs, preventing deadlock between dma-buf importers and exporters. Suggested-by: D