Re: [PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

2020-12-02 Thread kernel test robot
Hi Tomi, I love your patch! Perhaps something to improve: [auto build test WARNING on omap/for-next] [also build test WARNING on robh/for-next balbi-usb/testing/next linus/master v5.10-rc6] [cannot apply to next-20201201] [If your patch is applied to the wrong git tree, kindly drop us a note. An

Re: [PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

2020-12-01 Thread Tomi Valkeinen
On 01/12/2020 02:22, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Nov 24, 2020 at 02:45:26PM +0200, Tomi Valkeinen wrote: >> We have a useless 'if' in the dsicm_bl_update_status(), a left over from >> the conversion to DRM model. Drop the if. >> >> Signed-off-by: To

Re: [PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:26PM +0200, Tomi Valkeinen wrote: > We have a useless 'if' in the dsicm_bl_update_status(), a left over from > the conversion to DRM model. Drop the if. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/panel/panel-dsi-cm.

Re: [PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

2020-11-24 Thread Sam Ravnborg
Hi Tomi, On Tue, Nov 24, 2020 at 02:45:26PM +0200, Tomi Valkeinen wrote: > We have a useless 'if' in the dsicm_bl_update_status(), a left over from > the conversion to DRM model. Drop the if. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Sam Ravnborg But with a few comments. > --- > drivers

[PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

2020-11-24 Thread Tomi Valkeinen
We have a useless 'if' in the dsicm_bl_update_status(), a left over from the conversion to DRM model. Drop the if. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-dsi-cm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-dsi