Re: [PATCH v5] drm/vc4: fix fb references in async update

2019-06-13 Thread Greg KH
On Mon, Jun 10, 2019 at 10:18:59AM -0300, Helen Koike wrote: > commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets

Re: [PATCH v5] drm/vc4: fix fb references in async update

2019-06-10 Thread Helen Koike
On 6/10/19 10:18 AM, Helen Koike wrote: > commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets a reference of the

[PATCH v5] drm/vc4: fix fb references in async update

2019-06-10 Thread Helen Koike
commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. Async update callbacks are expected to set the old_fb in the new_state so prepare/cleanup framebuffers are balanced. Calling drm_atomic_set_fb_for_plane() (which gets a reference of the new fb and put the old fb) is not required, as it's t