Re: [PATCH v5] fbtft: add tearing signal detect

2021-01-27 Thread Geert Uytterhoeven
Hi Dan, Carlis, On Wed, Jan 27, 2021 at 9:32 AM Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote: > > hi,i will fix it like below: > > par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, > > GPIOD_IN); if (IS_ERR(par->gpio.te)) { > > rc =

[PATCH v5] fbtft: add tearing signal detect

2021-01-27 Thread Carlis
From: zhangxuezhi For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: zhangxuezhi --- v5:fix log print --- drivers/staging/fbtft/fb_st7789v.c | 128 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 128

Re: [PATCH v5] fbtft: add tearing signal detect

2021-01-27 Thread carlis
On Wed, 27 Jan 2021 08:45:23 +0300 Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 09:32:20AM +0800, Carlis wrote: > > @@ -82,6 +111,29 @@ enum st7789v_command { > > */ > > static int init_display(struct fbtft_par *par) > > { > > + int rc; > > + struct device *dev = par->info->device; > >

Re: [PATCH v5] fbtft: add tearing signal detect

2021-01-26 Thread Dan Carpenter
On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote: > hi,i will fix it like below: > par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, > GPIOD_IN); if (IS_ERR(par->gpio.te)) { > rc = PTR_ERR(par->gpio.te); > pr_err("Failed to request te gpio: %d\n",

Re: [PATCH v5] fbtft: add tearing signal detect

2021-01-26 Thread Dan Carpenter
On Wed, Jan 27, 2021 at 09:32:20AM +0800, Carlis wrote: > @@ -82,6 +111,29 @@ enum st7789v_command { > */ > static int init_display(struct fbtft_par *par) > { > + int rc; > + struct device *dev = par->info->device; > + > + par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,

Re: [PATCH v5] fbtft: add tearing signal detect

2021-01-26 Thread Dan Carpenter
On Wed, Jan 27, 2021 at 09:32:20AM +0800, Carlis wrote: > @@ -82,6 +111,29 @@ enum st7789v_command { > */ > static int init_display(struct fbtft_par *par) > { > + int rc; > + struct device *dev = par->info->device; > + > + par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,