Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-05-05 Thread Linus Walleij
On Mon, May 3, 2021 at 10:41 PM Doug Anderson wrote: > > At your convenience and when you think there is too little > > stuff in your sn65dsi86 TODO, check out > > pinctrl-bcm63xx.c for an example of select GPIO_REGMAP > > made very simple (this works fine as long as they are bit > > offsets

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-05-03 Thread Doug Anderson
Hi, On Sat, May 1, 2021 at 5:07 AM Linus Walleij wrote: > > Hi Doug, > > On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson wrote: > > > Pushed this one patch. Rest of the series is pending adult > > supervision. Overall summary: > > > > 1. I could probably push some of the early sn65dsi86 cleanup

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-05-01 Thread Linus Walleij
Hi Doug, On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson wrote: > Pushed this one patch. Rest of the series is pending adult > supervision. Overall summary: > > 1. I could probably push some of the early sn65dsi86 cleanup patches > in this series since they have Bjorn's review and are pretty

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-30 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 6:28 PM Linus Walleij wrote: > > On Fri, Apr 30, 2021 at 3:25 AM Doug Anderson wrote: > > > > I think pm_runtime_disable(); need to be added there? > > > > I'm a bit confused. You're saying that I need to add > > pm_runtime_disable() to panel_simple_remove()? Doesn't

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Doug Anderson
Hi, On Thu, Apr 29, 2021 at 5:58 PM Linus Walleij wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson > wrote: > > > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > > avoid excessive unprepare / prepare") we started using pm_runtime, but > > my patch neglected to

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Linus Walleij
On Fri, Apr 30, 2021 at 3:25 AM Doug Anderson wrote: > > I think pm_runtime_disable(); need to be added there? > > I'm a bit confused. You're saying that I need to add > pm_runtime_disable() to panel_simple_remove()? Doesn't this patch do > that? It does, sorry, too late at night :D I was

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-29 Thread Linus Walleij
On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson wrote: > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > avoid excessive unprepare / prepare") we started using pm_runtime, but > my patch neglected to add the proper pm_runtime_disable(). Doh! Add > them now. > > Fixes:

Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-28 Thread Sean Paul
On Fri, Apr 23, 2021 at 12:59 PM Douglas Anderson wrote: > > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > avoid excessive unprepare / prepare") we started using pm_runtime, but > my patch neglected to add the proper pm_runtime_disable(). Doh! Add > them now. > > Fixes:

[PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls

2021-04-23 Thread Douglas Anderson
In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") we started using pm_runtime, but my patch neglected to add the proper pm_runtime_disable(). Doh! Add them now. Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid