Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Thomas Zimmermann
Hi Am 17.05.23 um 19:03 schrieb Thomas Hellström: On Wed, 2023-05-17 at 17:29 +0100, Matthew Auld wrote: On 17/05/2023 17:05, Stanislaw Gruszka wrote: On Wed, May 17, 2023 at 04:22:38PM +0100, Matthew Auld wrote: In mutex_init() lockdep seems to identify a lock by defining a static key for

Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Thomas Zimmermann
Hi Am 17.05.23 um 19:04 schrieb Matthew Auld: On 17/05/2023 17:21, Thomas Zimmermann wrote: Hi Am 17.05.23 um 17:22 schrieb Matthew Auld: In mutex_init() lockdep seems to identify a lock by defining a static key for each lock class. However if we wrap the whole thing in a function the static

Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Matthew Auld
On 17/05/2023 17:21, Thomas Zimmermann wrote: Hi Am 17.05.23 um 17:22 schrieb Matthew Auld: In mutex_init() lockdep seems to identify a lock by defining a static key for each lock class. However if we wrap the whole thing in a function the static key will be the same for everything calling

Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Thomas Hellström
On Wed, 2023-05-17 at 17:29 +0100, Matthew Auld wrote: > On 17/05/2023 17:05, Stanislaw Gruszka wrote: > > On Wed, May 17, 2023 at 04:22:38PM +0100, Matthew Auld wrote: > > > In mutex_init() lockdep seems to identify a lock by defining a > > > static > > > key for each lock class. However if we

Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Matthew Auld
On 17/05/2023 17:05, Stanislaw Gruszka wrote: On Wed, May 17, 2023 at 04:22:38PM +0100, Matthew Auld wrote: In mutex_init() lockdep seems to identify a lock by defining a static key for each lock class. However if we wrap the whole thing in a function the static key will be the same for

Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Thomas Zimmermann
Hi Am 17.05.23 um 17:22 schrieb Matthew Auld: In mutex_init() lockdep seems to identify a lock by defining a static key for each lock class. However if we wrap the whole thing in a function the static key will be the same for everything calling that function, which looks to be the case for

Re: [PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Stanislaw Gruszka
On Wed, May 17, 2023 at 04:22:38PM +0100, Matthew Auld wrote: > In mutex_init() lockdep seems to identify a lock by defining a static > key for each lock class. However if we wrap the whole thing in a > function the static key will be the same for everything calling that > function, which looks to

[PATCH v5 1/7] drm: fix drmm_mutex_init()

2023-05-17 Thread Matthew Auld
In mutex_init() lockdep seems to identify a lock by defining a static key for each lock class. However if we wrap the whole thing in a function the static key will be the same for everything calling that function, which looks to be the case for drmm_mutex_init(). This then results in impossible