Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-18 Thread Luben Tuikov
One more very important thing! Once you add an R-V tag, you cannot change the patch and keep the R-V, when reposting it. If you change the code and thus the patch changes, you _*must*_ remove the R-V tag, to let people know that there's changes which need reviewing. Regards, Luben On 2023-10-

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-16 Thread Luben Tuikov
On 2023-10-16 11:08, Matthew Brost wrote: > On Fri, Oct 13, 2023 at 01:45:08PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> Rather than a global modparam for scheduling policy, move the scheduling >>> policy to scheduler so user can control each scheduler policy. >>>

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-16 Thread Matthew Brost
On Fri, Oct 13, 2023 at 01:45:08PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Rather than a global modparam for scheduling policy, move the scheduling > > policy to scheduler so user can control each scheduler policy. > > > > v2: > > - s/DRM_SCHED_POLICY_MAX/DRM_S

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-13 Thread Luben Tuikov
On 2023-10-11 19:58, Matthew Brost wrote: > Rather than a global modparam for scheduling policy, move the scheduling > policy to scheduler so user can control each scheduler policy. > > v2: > - s/DRM_SCHED_POLICY_MAX/DRM_SCHED_POLICY_COUNT (Luben) > - Only include policy in scheduler (Luben) >

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-13 Thread Luben Tuikov
On 2023-10-11 19:58, Matthew Brost wrote: > Rather than a global modparam for scheduling policy, move the scheduling > policy to scheduler so user can control each scheduler policy. > > v2: > - s/DRM_SCHED_POLICY_MAX/DRM_SCHED_POLICY_COUNT (Luben) > - Only include policy in scheduler (Luben) >

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Luben Tuikov
On 2023-10-12 00:31, Matthew Brost wrote: > On Wed, Oct 11, 2023 at 08:39:55PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> Rather than a global modparam for scheduling policy, move the scheduling >>> policy to scheduler so user can control each scheduler policy. >>>

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Matthew Brost
On Wed, Oct 11, 2023 at 08:39:55PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Rather than a global modparam for scheduling policy, move the scheduling > > policy to scheduler so user can control each scheduler policy. > > > > v2: > > - s/DRM_SCHED_POLICY_MAX/DRM_S

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Luben Tuikov
On 2023-10-11 19:58, Matthew Brost wrote: > Rather than a global modparam for scheduling policy, move the scheduling > policy to scheduler so user can control each scheduler policy. > > v2: > - s/DRM_SCHED_POLICY_MAX/DRM_SCHED_POLICY_COUNT (Luben) > - Only include policy in scheduler (Luben) >

[PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Matthew Brost
Rather than a global modparam for scheduling policy, move the scheduling policy to scheduler so user can control each scheduler policy. v2: - s/DRM_SCHED_POLICY_MAX/DRM_SCHED_POLICY_COUNT (Luben) - Only include policy in scheduler (Luben) v3: - use a ternary operator as opposed to an if-cont