Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Jagan Teki
On Mon, Nov 22, 2021 at 8:36 PM Maxime Ripard wrote: > > On Mon, Nov 22, 2021 at 08:01:47PM +0530, Jagan Teki wrote: > > On Mon, Nov 22, 2021 at 7:39 PM Maxime Ripard wrote: > > > > > > On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > > > > It's perfectly valid to dereference the

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Maxime Ripard
On Mon, Nov 22, 2021 at 08:01:47PM +0530, Jagan Teki wrote: > On Mon, Nov 22, 2021 at 7:39 PM Maxime Ripard wrote: > > > > On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > > > It's perfectly valid to dereference the pointer in atomic_enable, and > > > > that patch would consume

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Jagan Teki
On Mon, Nov 22, 2021 at 7:39 PM Maxime Ripard wrote: > > On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > > It's perfectly valid to dereference the pointer in atomic_enable, and > > > that patch would consume memory for no particular reason. > > > > Again, I'm not pointing any

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Maxime Ripard
On Mon, Nov 22, 2021 at 07:21:57PM +0530, Jagan Teki wrote: > > It's perfectly valid to dereference the pointer in atomic_enable, and > > that patch would consume memory for no particular reason. > > Again, I'm not pointing any mistake in dereference and certainly not > understand about what

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Jagan Teki
Hi Maxime, On Mon, Nov 22, 2021 at 6:58 PM Maxime Ripard wrote: > > On Mon, Nov 22, 2021 at 06:35:58PM +0530, Jagan Teki wrote: > > On Mon, Nov 22, 2021 at 3:38 PM Maxime Ripard wrote: > > > > > > On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > > > > Get the display mode settings

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Maxime Ripard
On Mon, Nov 22, 2021 at 06:35:58PM +0530, Jagan Teki wrote: > On Mon, Nov 22, 2021 at 3:38 PM Maxime Ripard wrote: > > > > On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > > > Get the display mode settings via mode_set bridge function > > > instead of explicitly de-reference. > > > >

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Jagan Teki
On Mon, Nov 22, 2021 at 3:38 PM Maxime Ripard wrote: > > On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > > Get the display mode settings via mode_set bridge function > > instead of explicitly de-reference. > > What's wrong with dereferencing the mode? Nothing wrong with

Re: [PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-22 Thread Maxime Ripard
On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > Get the display mode settings via mode_set bridge function > instead of explicitly de-reference. What's wrong with dereferencing the mode? Maxime signature.asc Description: PGP signature

[PATCH v5 4/7] drm: sun4i: dsi: Add mode_set function

2021-11-21 Thread Jagan Teki
Get the display mode settings via mode_set bridge function instead of explicitly de-reference. Signed-off-by: Jagan Teki --- Changes for v5: - new patch drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 12 +++- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 1 + 2 files changed, 12 insertions(+), 1