Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-24 Thread H. Nikolaus Schaller
Hi, > Am 23.04.2020 um 22:36 schrieb Maxime Ripard : >> My goal is to keep the bindings as minimalistic as possible. And reset >> lines and power domains are (at least for those we have in the works) >> not needed to make working systems. >> >> Therefore, for clocks I also would start with a

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Maxime Ripard
On Tue, Apr 21, 2020 at 06:42:17PM +0200, Philipp Rossak wrote: > Hi, > > On 21.04.20 13:21, Maxime Ripard wrote: > > Hi, > > > > On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: > > > On 20.04.20 09:38, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Fri, Apr 17, 2020 at

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread H. Nikolaus Schaller
Hi Neil, > Am 23.04.2020 um 17:00 schrieb Neil Armstrong : >> One thing we can learn is that "core" seems to be a de facto standard >> for the core clock-name. An alternative "gpu" is used by nvidia,gk20a.txt. > > Usually IPs needs a few clocks: > - pclk or apb or reg: the clock clocking the

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Maxime Ripard
On Thu, Apr 23, 2020 at 05:45:55PM +0200, H. Nikolaus Schaller wrote: > > Am 23.04.2020 um 17:00 schrieb Neil Armstrong : > >> One thing we can learn is that "core" seems to be a de facto standard > >> for the core clock-name. An alternative "gpu" is used by nvidia,gk20a.txt. > > > > Usually IPs

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Neil Armstrong
On 22/04/2020 18:09, H. Nikolaus Schaller wrote: > Hi Maxime, > >> Am 22.04.2020 um 17:13 schrieb Maxime Ripard : >> >> On Wed, Apr 22, 2020 at 09:10:57AM +0200, H. Nikolaus Schaller wrote: Am 22.04.2020 um 08:58 schrieb Maxime Ripard : > > It also allows to handle different number

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread H. Nikolaus Schaller
Hi Maxime, > Am 22.04.2020 um 17:13 schrieb Maxime Ripard : > > On Wed, Apr 22, 2020 at 09:10:57AM +0200, H. Nikolaus Schaller wrote: >>> Am 22.04.2020 um 08:58 schrieb Maxime Ripard : It also allows to handle different number of clocks (A31 seems to need 4, Samsung, A83 and

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread H. Nikolaus Schaller
Hi Maxime, > Am 22.04.2020 um 08:58 schrieb Maxime Ripard : > > On Tue, Apr 21, 2020 at 07:29:32PM +0200, H. Nikolaus Schaller wrote: >> >>> Am 21.04.2020 um 16:15 schrieb Tony Lindgren : >>> >>> * Maxime Ripard [200421 11:22]: On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Maxime Ripard
On Tue, Apr 21, 2020 at 07:29:32PM +0200, H. Nikolaus Schaller wrote: > > > Am 21.04.2020 um 16:15 schrieb Tony Lindgren : > > > > * Maxime Ripard [200421 11:22]: > >> On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: > >>> I had a look on genpd and I'm not really sure if that

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Maxime Ripard
On Wed, Apr 22, 2020 at 09:10:57AM +0200, H. Nikolaus Schaller wrote: > > Am 22.04.2020 um 08:58 schrieb Maxime Ripard : > > > > On Tue, Apr 21, 2020 at 07:29:32PM +0200, H. Nikolaus Schaller wrote: > >> > >>> Am 21.04.2020 um 16:15 schrieb Tony Lindgren : > >>> > >>> * Maxime Ripard [200421

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread Tony Lindgren
* Tony Lindgren [200421 10:39]: > See for example the standard 8250 uart for am335x with: > > $ git grep -B20 -A10 uart0 arch/arm/boot/dts/am33xx-l4.dtsi > > The 8250 device configuration is described in the standard 8250 > dts binding, and the am335x module in the ti-sysc binding. > The are

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread Tony Lindgren
* H. Nikolaus Schaller [200421 17:31]: > > Am 21.04.2020 um 16:15 schrieb Tony Lindgren : > > Note that on omaps there are actually SoC module specific registers. > > Ah, I see. This is of course a difference that the TI glue logic has > its own registers in the same address range as the sgx and

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread H. Nikolaus Schaller
> Am 21.04.2020 um 16:15 schrieb Tony Lindgren : > > * Maxime Ripard [200421 11:22]: >> On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: >>> I had a look on genpd and I'm not really sure if that fits. >>> >>> It is basically some bit that verify that the clocks should be

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread Maxime Ripard
Hi, On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: > On 20.04.20 09:38, Maxime Ripard wrote: > > Hi, > > > > On Fri, Apr 17, 2020 at 02:09:06PM +0200, Philipp Rossak wrote: > > > > > I'm a bit skeptical on that one since it doesn't even list the > > > > > interrupts connected to

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread Philipp Rossak
Hi, On 21.04.20 13:21, Maxime Ripard wrote: Hi, On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: On 20.04.20 09:38, Maxime Ripard wrote: Hi, On Fri, Apr 17, 2020 at 02:09:06PM +0200, Philipp Rossak wrote: I'm a bit skeptical on that one since it doesn't even list the

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread Tony Lindgren
* Maxime Ripard [200421 11:22]: > On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: > > I had a look on genpd and I'm not really sure if that fits. > > > > It is basically some bit that verify that the clocks should be enabled or > > disabled. > > No, it can do much more than

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-22 Thread Philipp Rossak
Hi, On 20.04.20 09:38, Maxime Ripard wrote: Hi, On Fri, Apr 17, 2020 at 02:09:06PM +0200, Philipp Rossak wrote: I'm a bit skeptical on that one since it doesn't even list the interrupts connected to the GPU that the binding mandates. I think he left it out for a future update. But best he

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-21 Thread Maxime Ripard
Hi, On Fri, Apr 17, 2020 at 02:09:06PM +0200, Philipp Rossak wrote: > > > I'm a bit skeptical on that one since it doesn't even list the > > > interrupts connected to the GPU that the binding mandates. > > > > I think he left it out for a future update. > > But best he comments himself. > > I'm

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-18 Thread Philipp Rossak
Hi all, On 15.04.20 15:04, H. Nikolaus Schaller wrote: Am 15.04.2020 um 15:02 schrieb Maxime Ripard : On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: The kernel modules built from this project have successfully demonstrated to work with the DTS definitions from this

[PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-16 Thread H. Nikolaus Schaller
* rebased to v5.7-rc1 * added DTS for for a31, a31s, a83t - by Philipp Rossak * added DTS for "samsung,s5pv210-sgx540-120" - by Jonathan Bakker * bindings.yaml fixes: - added a31, a31 - fixes for omap4470 - jz4780 contains an sgx540-130 and not -120 - a83t contains an sgx544-115 and not

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-16 Thread H. Nikolaus Schaller
> Am 15.04.2020 um 15:02 schrieb Maxime Ripard : > > On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: The kernel modules built from this project have successfully demonstrated to work with the DTS definitions from this patch set on AM335x BeagleBone Black,

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-16 Thread H. Nikolaus Schaller
Hi Maxime, > Am 15.04.2020 um 12:10 schrieb Maxime Ripard : > > Hi, > > On Wed, Apr 15, 2020 at 10:35:07AM +0200, H. Nikolaus Schaller wrote: >> * rebased to v5.7-rc1 >> * added DTS for for a31, a31s, a83t - by Philipp Rossak >> * added DTS for "samsung,s5pv210-sgx540-120" - by Jonathan Bakker

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-16 Thread Maxime Ripard
On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: > >> The kernel modules built from this project have successfully > >> demonstrated to work with the DTS definitions from this patch set on > >> AM335x BeagleBone Black, DM3730 and OMAP5 Pyra and Droid 4. They > >> partially

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-16 Thread Maxime Ripard
Hi, On Wed, Apr 15, 2020 at 10:35:07AM +0200, H. Nikolaus Schaller wrote: > * rebased to v5.7-rc1 > * added DTS for for a31, a31s, a83t - by Philipp Rossak > * added DTS for "samsung,s5pv210-sgx540-120" - by Jonathan Bakker > > * bindings.yaml fixes: > - added a31, a31 > - fixes for

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: > Hi Maxime, > > > Am 15.04.2020 um 12:10 schrieb Maxime Ripard : > > > > Hi, > > > > On Wed, Apr 15, 2020 at 10:35:07AM +0200, H. Nikolaus Schaller wrote: > >> * rebased to v5.7-rc1 > >> * added DTS for for a31, a31s, a83t -