Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-13 Thread Jocelyn Falempe
On 13/08/2024 16:11, Jani Nikula wrote: On Mon, 12 Aug 2024, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: On 12/08/2024 15:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but th

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-13 Thread Jani Nikula
On Mon, 12 Aug 2024, Jani Nikula wrote: > On Mon, 12 Aug 2024, Jocelyn Falempe wrote: >> On 12/08/2024 15:49, Jani Nikula wrote: >>> On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the re

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jani Nikula
On Mon, 12 Aug 2024, Jocelyn Falempe wrote: > On 12/08/2024 15:49, Jani Nikula wrote: >> On Mon, 12 Aug 2024, Jocelyn Falempe wrote: >>> Check if two rectangles overlap. >>> It's a bit similar to drm_rect_intersect() but this won't modify >>> the rectangle. >>> Simplifies a bit drm_panic. >> >>

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jocelyn Falempe
On 12/08/2024 15:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Based on the name, I'd expect drm_rect_overlap() to return true f

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Hamza Mahfooz
On 8/12/24 09:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Based on the name, I'd expect drm_rect_overlap() to return true for *an

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jani Nikula
On Mon, 12 Aug 2024, Jocelyn Falempe wrote: > Check if two rectangles overlap. > It's a bit similar to drm_rect_intersect() but this won't modify > the rectangle. > Simplifies a bit drm_panic. Based on the name, I'd expect drm_rect_overlap() to return true for *any* overlap, while this one seems

[PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jocelyn Falempe
Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 3 +-- include/drm/drm_rect.h | 15 +++ 2 files changed, 16 insertions(+