Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

01.11.2020 18:57, Chanwoo Choi пишет: > On Mon, Nov 2, 2020 at 12:49 AM Dmitry Osipenko wrote: >> >> 01.11.2020 18:44, Chanwoo Choi пишет: OPP core will try to grab the clock reference for the table and it may cause EPROBE_DEFER. Although, it shouldn't happen here because we have

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

01.11.2020 18:44, Chanwoo Choi пишет: >>> I recommend that you use dev_pm_opp_of_get_opp_desc_node(>dev) >>> to check whether a device contains opp-table or not. >> I'm not sure what are the benefits, this will make code less >> expressive/readable and we will need to add extra of_node_put(),

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

01.11.2020 18:44, Chanwoo Choi пишет: >> OPP core will try to grab the clock reference for the table and it may >> cause EPROBE_DEFER. Although, it shouldn't happen here because we have >> devm_clk_get() before the get_opp_table(), hence seems the deferred >> probe indeed shouldn't happen in this

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

01.11.2020 17:44, Chanwoo Choi пишет: > Hi Dmitry, > > On Mon, Oct 26, 2020 at 7:22 AM Dmitry Osipenko wrote: >> >> This patch moves ACTMON driver away from generating OPP table by itself, >> transitioning it to use the table which comes from device-tree. This >> change breaks compatibility with

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

01.11.2020 17:39, Chanwoo Choi пишет: > Hi Dmitry, > > On Mon, Oct 26, 2020 at 7:22 AM Dmitry Osipenko wrote: >> >> This patch moves ACTMON driver away from generating OPP table by itself, >> transitioning it to use the table which comes from device-tree. This >> change breaks compatibility with

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

On Mon, Nov 2, 2020 at 12:49 AM Dmitry Osipenko wrote: > > 01.11.2020 18:44, Chanwoo Choi пишет: > >> OPP core will try to grab the clock reference for the table and it may > >> cause EPROBE_DEFER. Although, it shouldn't happen here because we have > >> devm_clk_get() before the get_opp_table(),

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

Hi Dmitry, On Mon, Nov 2, 2020 at 12:24 AM Dmitry Osipenko wrote: > > 01.11.2020 17:44, Chanwoo Choi пишет: > > Hi Dmitry, > > > > On Mon, Oct 26, 2020 at 7:22 AM Dmitry Osipenko wrote: > >> > >> This patch moves ACTMON driver away from generating OPP table by itself, > >> transitioning it to

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

Hi Dmitry, On Mon, Nov 2, 2020 at 12:23 AM Dmitry Osipenko wrote: > > 01.11.2020 17:39, Chanwoo Choi пишет: > > Hi Dmitry, > > > > On Mon, Oct 26, 2020 at 7:22 AM Dmitry Osipenko wrote: > >> > >> This patch moves ACTMON driver away from generating OPP table by itself, > >> transitioning it to

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

Hi Dmitry, On Mon, Oct 26, 2020 at 7:22 AM Dmitry Osipenko wrote: > > This patch moves ACTMON driver away from generating OPP table by itself, > transitioning it to use the table which comes from device-tree. This > change breaks compatibility with older device-trees in order to bring > support

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

Hi Dmitry, On Mon, Oct 26, 2020 at 7:22 AM Dmitry Osipenko wrote: > > This patch moves ACTMON driver away from generating OPP table by itself, > transitioning it to use the table which comes from device-tree. This > change breaks compatibility with older device-trees in order to bring > support

[PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

This patch moves ACTMON driver away from generating OPP table by itself, transitioning it to use the table which comes from device-tree. This change breaks compatibility with older device-trees in order to bring support for the interconnect framework to the driver. This is a mandatory change which