Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

2021-06-16 Thread Jon Hunter
Hi Mikko, On 10/06/2021 12:04, Mikko Perttunen wrote: > Implement the job submission IOCTL with a minimum feature set. > > Signed-off-by: Mikko Perttunen > --- > v7: > * Allocate gather BO with DMA API to get page-aligned > memory > * Add error prints to a few places where they were missing >

Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

2021-06-15 Thread Dmitry Osipenko
10.06.2021 14:04, Mikko Perttunen пишет: > +drop_refs: > + for (;;) { > + if (i-- == 0) > + break; > + while(i--) ?

Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

2021-06-15 Thread Dmitry Osipenko
10.06.2021 14:04, Mikko Perttunen пишет: > +++ b/drivers/gpu/drm/tegra/gather_bo.c > @@ -0,0 +1,82 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* Copyright (c) 2020 NVIDIA Corporation */ > + > +#include > +#include > +#include > + > +#include "gather_bo.h" > + ... > +const struct

Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

2021-06-15 Thread Mikko Perttunen
On 6/15/21 10:00 PM, Jon Hunter wrote: On 10/06/2021 12:04, Mikko Perttunen wrote: Implement the job submission IOCTL with a minimum feature set. Signed-off-by: Mikko Perttunen --- v7: * Allocate gather BO with DMA API to get page-aligned memory * Add error prints to a few places where

Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

2021-06-15 Thread Jon Hunter
On 10/06/2021 12:04, Mikko Perttunen wrote: > Implement the job submission IOCTL with a minimum feature set. > > Signed-off-by: Mikko Perttunen > --- > v7: > * Allocate gather BO with DMA API to get page-aligned > memory > * Add error prints to a few places where they were missing > v6: > *

[PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

2021-06-10 Thread Mikko Perttunen
Implement the job submission IOCTL with a minimum feature set. Signed-off-by: Mikko Perttunen --- v7: * Allocate gather BO with DMA API to get page-aligned memory * Add error prints to a few places where they were missing v6: * Remove sgt bypass path in gather_bo - this would cause cache