Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-23 Thread Simon Ser
On Monday, October 23rd, 2023 at 10:42, Michel Dänzer wrote: > On 10/23/23 10:27, Simon Ser wrote: > > > On Sunday, October 22nd, 2023 at 12:12, Michel Dänzer > > michel.daen...@mailbox.org wrote: > > > > > On 10/17/23 14:16, Simon Ser wrote: > > > > > > > After discussing with André it seem

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-23 Thread Michel Dänzer
On 10/23/23 10:27, Simon Ser wrote: > On Sunday, October 22nd, 2023 at 12:12, Michel Dänzer > wrote: >> On 10/17/23 14:16, Simon Ser wrote: >> >>> After discussing with André it seems like we missed a plane type check >>> here. We need to make sure FB_ID changes are only allowed on primary >>> pl

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-23 Thread Simon Ser
On Sunday, October 22nd, 2023 at 12:12, Michel Dänzer wrote: > On 10/17/23 14:16, Simon Ser wrote: > > > After discussing with André it seems like we missed a plane type check > > here. We need to make sure FB_ID changes are only allowed on primary > > planes. > > Can you elaborate why that's

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-22 Thread Michel Dänzer
On 10/17/23 14:16, Simon Ser wrote: > After discussing with André it seems like we missed a plane type check > here. We need to make sure FB_ID changes are only allowed on primary > planes. Can you elaborate why that's needed? -- Earthling Michel Dänzer| https://red

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-17 Thread kernel test robot
s/20231017-173047 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231017092837.32428-5-andrealmeid%40igalia.com patch subject: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes config: m68k-allyesconfig (https://download.0

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-17 Thread Simon Ser
After discussing with André it seems like we missed a plane type check here. We need to make sure FB_ID changes are only allowed on primary planes.

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-17 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-17 Thread André Almeida
Given that prop changes may lead to modesetting, which would defeat the fast path of the async flip, refuse any atomic prop change for async flips in atomic API. The only exceptions are the framebuffer ID to flip to and the mode ID, that could be referring to an identical mode. Signed-off-by: Andr