Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

Hi Nicolas, Thanks for the review. On 15/05/24 01:52, Nicolas Dufresne wrote: > Le samedi 11 mai 2024 à 22:38 +0530, Devarsh Thakkar a écrit : >> Hi Andy, >> >> Thanks for the quick review. >> On 10/05/24 20:40, Andy Shevchenko wrote: >>> On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

Le samedi 11 mai 2024 à 22:38 +0530, Devarsh Thakkar a écrit : > Hi Andy, > > Thanks for the quick review. > On 10/05/24 20:40, Andy Shevchenko wrote: > > On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote: > > > If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up >

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

Hi Andy, Thanks for the quick review. On 10/05/24 20:40, Andy Shevchenko wrote: > On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote: >> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up >> (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest >>

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote: > If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up > (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest > multiple of requested value while updating the crop rectangle coordinates. > > Use the

[PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest multiple of requested value while updating the crop rectangle coordinates. Use the rounding macro which gives preference to rounding down in case two nearest