Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread H. Nikolaus Schaller
Hi Paul, >>> You probably should disable the regulator (if not NULL) here. >> Indeed. Would it be ok to make struct regulator *regulator static >> or do we need dynamically allocated memory? > > static non-const is almost always a bad idea, so avoid it. Well some years ago it was a perfectly si

Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread Paul Cercueil
Hi Nikolaus, Le mer., nov. 24 2021 at 17:13:30 +0100, H. Nikolaus Schaller a écrit : Am 23.11.2021 um 21:05 schrieb Paul Cercueil : Hi Nikolaus, I keep seeing a few things, sorry. no problem. Le mar., nov. 23 2021 at 19:13:57 +0100, H. Nikolaus Schaller a écrit : From: Paul

Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-24 Thread H. Nikolaus Schaller
> Am 23.11.2021 um 21:05 schrieb Paul Cercueil : > > Hi Nikolaus, > > I keep seeing a few things, sorry. no problem. > > > Le mar., nov. 23 2021 at 19:13:57 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> A specialisation of the generic Synopsys HDMI driver is employed f

Re: [PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-23 Thread Paul Cercueil
Hi Nikolaus, I keep seeing a few things, sorry. Le mar., nov. 23 2021 at 19:13:57 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration

[PATCH v8 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-23 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Signed-off-by: Paul Boddie Signed-off-by: