Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Marijn Suijten
On 2023-05-15 10:06:33, Kuogee Hsieh wrote: > >> +static inline int _dsc_calc_ob_max_addr(struct dpu_hw_dsc *hw_dsc, int > >> num_ss) > > Can you write out "ob" fully? > > > > These don't need to be marked "inline", same below. Please add newlines around your reply, like I did here, to make it e

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Marijn Suijten
On 2023-05-15 10:46:48, Kuogee Hsieh wrote: > > Friendly request to strip/snip unneeded context (as done in this reply) > > to make it easier to spot the conversation, and replies to it. > > > > - Marijn > > Thanks for suggestion. > > How can I do that? > > just manually delete unneeded context

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Dmitry Baryshkov
On Mon, 15 May 2023 at 20:47, Kuogee Hsieh wrote: > > > On 5/14/2023 2:46 PM, Marijn Suijten wrote: > > On 2023-05-12 21:19:19, Dmitry Baryshkov wrote: > > >>> +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc > >>> *hw_dsc, > >>> +

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
On 5/14/2023 2:46 PM, Marijn Suijten wrote: On 2023-05-12 21:19:19, Dmitry Baryshkov wrote: +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc *hw_dsc, + const enum dpu_pingpong pp) +{ + struct dpu_hw_blk_reg_map *hw;

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
On 5/14/2023 3:18 PM, Marijn Suijten wrote: On 2023-05-12 11:00:20, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
On 5/14/2023 3:18 PM, Marijn Suijten wrote: On 2023-05-12 11:00:20, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-14 Thread Marijn Suijten
On 2023-05-12 11:00:20, Kuogee Hsieh wrote: > > Add support for DSC 1.2 by providing the necessary hooks to program > the DPU DSC 1.2 encoder. > > Changes in v3: > -- fixed kernel test rebot report that "__iomem *off" is declared but not >used at dpu_hw_dsc_config_1_2() > -- unrolling thresh

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-14 Thread Marijn Suijten
On 2023-05-12 21:19:19, Dmitry Baryshkov wrote: > +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc > > *hw_dsc, > > + const enum dpu_pingpong pp) > > +{ > > + struct dpu_hw_blk_reg_map *hw; > > + const struct dpu_dsc_sub_blks

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 23:48, Kuogee Hsieh wrote: On 5/12/2023 11:19 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Kuogee Hsieh
On 5/12/2023 11:19 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not     used at dpu_hw_ds

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:00, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes in

[PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes in v4: -- delete DPU_DSC_HW_REV_1_1 -- delete