Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-15 Thread Marijn Suijten
On 2023-05-12 11:00:21, Kuogee Hsieh wrote: > > Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). Can you rewrite "is piggyback"? Something like "Currently DSC flushing happens during interface configuration". And it's intf configuration **on the CTL**, which makes this

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Abhinav Kumar
On 5/12/2023 11:50 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:47, Abhinav Kumar wrote: On 5/12/2023 11:21 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:47, Abhinav Kumar wrote: On 5/12/2023 11:21 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Abhinav Kumar
On 5/12/2023 11:21 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to

[PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush