Re: [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-07 Thread Siddh Raman Pant
On Tue, 06 Jun 2023 18:25:37 +0530, Laurent Pinchart wrote: > Hi Siddh, > > Thank you for the patch. Anytime :) > Any chance we could prevent this from happening by turning the macros > into inline functions ? The next patch in the series almost does that, with a function introduced as Jani men

[PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-07 Thread Siddh Raman Pant
This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. It used an incorrect way to use drm_* functions. Only drm_device ptrs should be passed, but the mentioned commit passed mipi_dsi_host ptr. It worked by accident due to macro magic. Reported-by: Jani Nikula Reviewed-by: Jani Nikula Si

Re: [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-06 Thread Jani Nikula
On Tue, 06 Jun 2023, Laurent Pinchart wrote: > Hi Siddh, > > Thank you for the patch. > > On Tue, Jun 06, 2023 at 04:15:15PM +0530, Siddh Raman Pant wrote: >> This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. >> >> It used an incorrect way to use drm_* functions. Only drm_device ptrs

Re: [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-06 Thread Laurent Pinchart
Hi Siddh, Thank you for the patch. On Tue, Jun 06, 2023 at 04:15:15PM +0530, Siddh Raman Pant wrote: > This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. > > It used an incorrect way to use drm_* functions. Only drm_device ptrs > should be passed, but the mentioned commit passed mipi_