Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread C, Ramalingam
On 12/20/2018 9:36 PM, Winkler, Tomas wrote: +static void __exit mei_hdcp_exit(void) +{ +   mei_hdcp_component_cleanup(&cldev->dev); Don’t think you can do that,  no guarantees this will be valid pointer As we discussed offline, we have the below line at cleanup. So valid pointer is made s

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread Winkler, Tomas
From: C, Ramalingam Sent: Thursday, December 20, 2018 18:00 To: Daniel Vetter ; Winkler, Tomas Cc: Greg KH ; Rafael J. Wysocki ; intel-gfx ; dri-devel ; Sean Paul ; Shankar, Uma ; Syrjala, Ville ; Chris Wilson Subject: Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread C, Ramalingam
On 12/19/2018 12:15 PM, C, Ramalingam wrote: Tomas and Daniel, From the discussion on this thread, I infer following understanding: * At present(v9) I915 wants to be hard binded to mei_hdcp device-driver binding status through components o This means I915 driver load will get comp

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-18 Thread C, Ramalingam
Tomas and Daniel, From the discussion on this thread, I infer following understanding: * At present(v9) I915 wants to be hard binded to mei_hdcp device-driver binding status through components o This means I915 driver load will get complete only when the mei_hdcp's device and dri

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-17 Thread Daniel Vetter
On Mon, Dec 17, 2018 at 11:57 AM Winkler, Tomas wrote: > > > > On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote: > > > > > > > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > > > > > > > > wrote: > > > > > > > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > > > > > > >

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-17 Thread Winkler, Tomas
> On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote: > > > > > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > > > > > > wrote: > > > > > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > > > > > > > > > wrote: > > > > > > > > > > > > Tomas and Daniel, > > > > > > > > > >

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-17 Thread Daniel Vetter
On Mon, Dec 17, 2018 at 10:39:07AM +0100, Daniel Vetter wrote: > On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote: > > > > > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > > > wrote: > > > > > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > > > > > > > > > wrote: > >

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-17 Thread Daniel Vetter
On Sat, Dec 15, 2018 at 09:20:38PM +, Winkler, Tomas wrote: > > > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > > wrote: > > > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > > > > > > > wrote: > > > > > > > > > > Tomas and Daniel, > > > > > > > > > > We got an issue here. > >

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-15 Thread Winkler, Tomas
> > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > wrote: > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > > > > > wrote: > > > > > > > > Tomas and Daniel, > > > > > > > > We got an issue here. > > > > > > > > The relationship that we try to build between I915 and mei_hdcp is as > f

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-13 Thread Daniel Vetter
On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas wrote: > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > wrote: > > > > > > Tomas and Daniel, > > > > > > We got an issue here. > > > > > > The relationship that we try to build between I915 and mei_hdcp is as > > > follows: > > > > > > We are

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-13 Thread Winkler, Tomas
> On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > wrote: > > > > Tomas and Daniel, > > > > We got an issue here. > > > > The relationship that we try to build between I915 and mei_hdcp is as > > follows: > > > > We are using the components to establish the relationship. > > I915 is component mast

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-13 Thread Daniel Vetter
On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam wrote: > > Tomas and Daniel, > > We got an issue here. > > The relationship that we try to build between I915 and mei_hdcp is as follows: > > We are using the components to establish the relationship. > I915 is component master where as mei_hdcp is com

Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-13 Thread C, Ramalingam
Tomas and Daniel, We got an issue here. The relationship that we try to build between I915 and mei_hdcp is as follows: * We are using the components to establish the relationship. * I915 is component master where as mei_hdcp is component. * I915 adds the component master during the module lo

[PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-12 Thread Ramalingam C
Mei hdcp driver is designed as component slave for the I915 component master. v2: Rebased. v3: Notifier chain is adopted for cldev state update [Tomas] v4: Made static dummy functions as inline in mei_hdcp.h API for polling client device status IS_ENABLED used in header, for config status