RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Jani Nikula
On Wed, 25 Sep 2024, "Murthy, Arun R" wrote: >> >> > +static __inline__ void set_bin_index_0(struct intel_display >> >> > +*display, enum pipe pipe) >> >> ^^ >> >> >> >> Why? >> >> >> > Sorry, didn't get your question. Is it why "enum pipe pipe" >> >> No, why __inline__? What's

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Murthy, Arun R
> >> > +static __inline__ void set_bin_index_0(struct intel_display > >> > +*display, enum pipe pipe) > >> ^^ > >> > >> Why? > >> > > Sorry, didn't get your question. Is it why "enum pipe pipe" > > No, why __inline__? What's the point? > > (I tried to underline it with ^

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Jani Nikula
On Wed, 25 Sep 2024, "Murthy, Arun R" wrote: >> > .../gpu/drm/i915/display/intel_histogram.c| 111 +- >> > .../drm/i915/display/intel_histogram_reg.h| 25 >> > 2 files changed, 105 insertions(+), 31 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/i915/display/int

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Murthy, Arun R
> > .../gpu/drm/i915/display/intel_histogram.c| 111 +- > > .../drm/i915/display/intel_histogram_reg.h| 25 > > 2 files changed, 105 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c > > b/drivers/gpu/drm/i915/display/i

Re: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Jani Nikula
On Thu, 19 Sep 2024, Arun R Murthy wrote: > In Display 20+, new registers are added for setting index, reading > histogram and writing the IET. > > v2: Removed duplicate code (Jani) > v3: Moved histogram core changes to earlier patches (Jani/Suraj) > > Signed-off-by: Arun R Murthy > --- > .../gp

[PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-19 Thread Arun R Murthy
In Display 20+, new registers are added for setting index, reading histogram and writing the IET. v2: Removed duplicate code (Jani) v3: Moved histogram core changes to earlier patches (Jani/Suraj) Signed-off-by: Arun R Murthy --- .../gpu/drm/i915/display/intel_histogram.c| 111 +