[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-03 Thread Mark Zhang
On 01/03/2013 01:50 PM, Terje Bergstr?m wrote: > On 03.01.2013 05:31, Mark Zhang wrote: >> Sorry I didn't get it. Yes, in current design, you can pin all mem >> handles in one time but I haven't found anything related with "locking >> only once per submit". >> >> My idea is: >> - remove

[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-03 Thread Mark Zhang
On 01/02/2013 05:42 PM, Terje Bergstr?m wrote: > On 28.12.2012 11:14, Mark Zhang wrote: >> diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c >> index a936902..c3ded60 100644 >> --- a/drivers/gpu/drm/tegra/gr2d.c >> +++ b/drivers/gpu/drm/tegra/gr2d.c >> @@ -131,6 +131,14 @@

[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-03 Thread Mark Zhang
On 01/02/2013 05:25 PM, Terje Bergstr?m wrote: > On 26.12.2012 11:42, Mark Zhang wrote: [...] > >> >> if (!de) >> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c >> index 07e8813..01ed10d 100644 >> --- a/drivers/gpu/host1x/dev.c >> +++ b/drivers/gpu/host1x/dev.c >> @@

[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-03 Thread Terje Bergström
On 21.12.2012 15:50, Lucas Stach wrote: > Am Freitag, den 21.12.2012, 13:39 +0200 schrieb Terje Bergstrom: >> Some of the issues left open: >> * Register definitions still use static inline. There has been a >>debate about code style versus ability to use compiler type >>checking and code

[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-03 Thread Terje Bergström
On 03.01.2013 05:31, Mark Zhang wrote: > Sorry I didn't get it. Yes, in current design, you can pin all mem > handles in one time but I haven't found anything related with "locking > only once per submit". > > My idea is: > - remove "job->addr_phys" > - assign "job->reloc_addr_phys" &

[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Terje Bergström
On 28.12.2012 11:14, Mark Zhang wrote: > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c > index a936902..c3ded60 100644 > --- a/drivers/gpu/drm/tegra/gr2d.c > +++ b/drivers/gpu/drm/tegra/gr2d.c > @@ -131,6 +131,14 @@ static int gr2d_submit(struct tegra_drm_context >

[PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Terje Bergström
On 26.12.2012 11:42, Mark Zhang wrote: > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c > index a936902..28954b3 100644 > --- a/drivers/gpu/drm/tegra/gr2d.c > +++ b/drivers/gpu/drm/tegra/gr2d.c > @@ -247,6 +247,10 @@ static int __devinit gr2d_probe(struct >

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Terje Bergström
On 26.12.2012 11:42, Mark Zhang wrote: diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index a936902..28954b3 100644 --- a/drivers/gpu/drm/tegra/gr2d.c +++ b/drivers/gpu/drm/tegra/gr2d.c @@ -247,6 +247,10 @@ static int __devinit gr2d_probe(struct platform_device

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Terje Bergström
On 28.12.2012 11:14, Mark Zhang wrote: diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index a936902..c3ded60 100644 --- a/drivers/gpu/drm/tegra/gr2d.c +++ b/drivers/gpu/drm/tegra/gr2d.c @@ -131,6 +131,14 @@ static int gr2d_submit(struct tegra_drm_context *context,

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:25 PM, Terje Bergström wrote: On 26.12.2012 11:42, Mark Zhang wrote: [...] if (!de) diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c index 07e8813..01ed10d 100644 --- a/drivers/gpu/host1x/dev.c +++ b/drivers/gpu/host1x/dev.c @@ -38,6 +38,7 @@

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:42 PM, Terje Bergström wrote: On 28.12.2012 11:14, Mark Zhang wrote: diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index a936902..c3ded60 100644 --- a/drivers/gpu/drm/tegra/gr2d.c +++ b/drivers/gpu/drm/tegra/gr2d.c @@ -131,6 +131,14 @@ static int

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Terje Bergström
On 03.01.2013 05:31, Mark Zhang wrote: Sorry I didn't get it. Yes, in current design, you can pin all mem handles in one time but I haven't found anything related with locking only once per submit. My idea is: - remove job-addr_phys - assign job-reloc_addr_phys job-gather_addr_phys

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Mark Zhang
On 01/03/2013 01:50 PM, Terje Bergström wrote: On 03.01.2013 05:31, Mark Zhang wrote: Sorry I didn't get it. Yes, in current design, you can pin all mem handles in one time but I haven't found anything related with locking only once per submit. My idea is: - remove job-addr_phys - assign

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Terje Bergström
On 21.12.2012 15:50, Lucas Stach wrote: Am Freitag, den 21.12.2012, 13:39 +0200 schrieb Terje Bergstrom: Some of the issues left open: * Register definitions still use static inline. There has been a debate about code style versus ability to use compiler type checking and code coverage

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-28 Thread Mark Zhang
Hi Terje, Here is the second part comments. I admit I still haven't finished reading the codes... really too many codes. :) Anyway I'll keep doing this when I have free slots. diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index a936902..c3ded60 100644 ---

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-28 Thread Mark Zhang
Hi Terje, Here is the second part comments. I admit I still haven't finished reading the codes... really too many codes. :) Anyway I'll keep doing this when I have free slots. diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index a936902..c3ded60 100644 ---

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-26 Thread Mark Zhang
Hi Terje, I applied your patches on top of upstream 1224 kernel. Then I read the codes. So here is my review comments(I use "git diff" to print out, check below). I admit it's easy for me to not need to find the corresponding lines in your 8 patch mails, but I've no idea whether it is ok for you.

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-26 Thread Mark Zhang
Hi Terje, I applied your patches on top of upstream 1224 kernel. Then I read the codes. So here is my review comments(I use git diff to print out, check below). I admit it's easy for me to not need to find the corresponding lines in your 8 patch mails, but I've no idea whether it is ok for you.

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Terje Bergström
On 21.12.2012 15:50, Lucas Stach wrote: > This has to be resolved before merging. Personally I'm in favour of > keeping reg access patterns close to what is done in other parts of the > kernel. I haven't so far received comments from too many people, so that's why I left it as is. >> * Uses

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Lucas Stach
Am Freitag, den 21.12.2012, 15:57 +0200 schrieb Terje Bergstr?m: > On 21.12.2012 15:50, Lucas Stach wrote: > > This has to be resolved before merging. Personally I'm in favour of > > keeping reg access patterns close to what is done in other parts of the > > kernel. > > I haven't so far received

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Lucas Stach
Am Freitag, den 21.12.2012, 13:39 +0200 schrieb Terje Bergstrom: > This set of patches adds support for Tegra20 and Tegra30 host1x and > 2D. It is based on linux-next-20121220. > > The fourth version has only few changes compared to previous version: > * Fixed some sparse warnings > * Fixed

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Terje Bergstrom
This set of patches adds support for Tegra20 and Tegra30 host1x and 2D. It is based on linux-next-20121220. The fourth version has only few changes compared to previous version: * Fixed some sparse warnings * Fixed host1x Makefile to allow building as module * Fixed host1x module unload *

[PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Terje Bergstrom
This set of patches adds support for Tegra20 and Tegra30 host1x and 2D. It is based on linux-next-20121220. The fourth version has only few changes compared to previous version: * Fixed some sparse warnings * Fixed host1x Makefile to allow building as module * Fixed host1x module unload *

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Lucas Stach
Am Freitag, den 21.12.2012, 13:39 +0200 schrieb Terje Bergstrom: This set of patches adds support for Tegra20 and Tegra30 host1x and 2D. It is based on linux-next-20121220. The fourth version has only few changes compared to previous version: * Fixed some sparse warnings * Fixed host1x

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Terje Bergström
On 21.12.2012 15:50, Lucas Stach wrote: This has to be resolved before merging. Personally I'm in favour of keeping reg access patterns close to what is done in other parts of the kernel. I haven't so far received comments from too many people, so that's why I left it as is. * Uses still

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-21 Thread Lucas Stach
Am Freitag, den 21.12.2012, 15:57 +0200 schrieb Terje Bergström: On 21.12.2012 15:50, Lucas Stach wrote: This has to be resolved before merging. Personally I'm in favour of keeping reg access patterns close to what is done in other parts of the kernel. I haven't so far received comments