[PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergstrom
From: Arto Merilainen This patch removes the redundant host1x driver from tegradrm and makes necessary bindings to the separate host driver. The infrastructure for drm client lists is merged to drm.c. The patch simplifies driver initialization; The original driver had two lists for registered d

[PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergstrom
From: Arto Merilainen This patch removes the redundant host1x driver from tegradrm and makes necessary bindings to the separate host driver. The infrastructure for drm client lists is merged to drm.c. The patch simplifies driver initialization; The original driver had two lists for registered d

[PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergstrom
From: Arto Merilainen This patch removes the redundant host1x driver from tegradrm and makes necessary bindings to the separate host driver. The infrastructure for drm client lists is merged to drm.c. The patch simplifies driver initialization; The original driver had two lists for registered d

[PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergstrom
From: Arto Merilainen This patch removes the redundant host1x driver from tegradrm and makes necessary bindings to the separate host driver. The infrastructure for drm client lists is merged to drm.c. The patch simplifies driver initialization; The original driver had two lists for registered d

[PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergstrom
From: Arto Merilainen This patch removes the redundant host1x driver from tegradrm and makes necessary bindings to the separate host driver. The infrastructure for drm client lists is merged to drm.c. The patch simplifies driver initialization; The original driver had two lists for registered d

[PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergstrom
From: Arto Merilainen This patch removes the redundant host1x driver from tegradrm and makes necessary bindings to the separate host driver. The infrastructure for drm client lists is merged to drm.c. The patch simplifies driver initialization; The original driver had two lists for registered d

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Thierry Reding
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen [...] > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c [...] > +static int tegra_drm_add_client(struct device *dev, void *data) > +{ > + static const char * const compat[] = { > +

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static struct platform_driver tegra_drm_platform_driver = { >> +.driver = { >> +.name = "tegradrm", > > This should be "tegra-drm" to match the module name. We've actu

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-24 Thread Stephen Warren
On 12/21/2012 11:50 PM, Terje Bergström wrote: > On 21.12.2012 16:36, Thierry Reding wrote: >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >>> +static struct platform_driver tegra_drm_platform_driver = { >>> + .driver = { >>> + .name = "tegradrm", >> >> This should

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-28 Thread Thierry Reding
On Mon, Dec 24, 2012 at 10:25:00PM -0700, Stephen Warren wrote: > On 12/21/2012 11:50 PM, Terje Bergström wrote: > > On 21.12.2012 16:36, Thierry Reding wrote: > >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > >>> +static struct platform_driver tegra_drm_platform_driver = { >

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-30 Thread Terje Bergström
On 28.12.2012 23:21, Thierry Reding wrote: > Instead of going over this back and forth, I've decided to rewrite this > patch from scratch the way I think it should be done. Maybe that'll make > things clearer. I haven't tested it on real hardware yet because I don't > have access over the holidays,

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2013-01-03 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) >> +{ >> + >> +} >> + > > This can be removed, right? Yes, done. > >> +static struct platform_driver tegra

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Thierry Reding
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen [...] > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c [...] > +static int tegra_drm_add_client(struct device *dev, void *data) > +{ > + static const char * const compat[] = { > +

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static struct platform_driver tegra_drm_platform_driver = { >> +.driver = { >> +.name = "tegradrm", > > This should be "tegra-drm" to match the module name. We've actu

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-24 Thread Stephen Warren
On 12/21/2012 11:50 PM, Terje Bergström wrote: > On 21.12.2012 16:36, Thierry Reding wrote: >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >>> +static struct platform_driver tegra_drm_platform_driver = { >>> + .driver = { >>> + .name = "tegradrm", >> >> This should

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-28 Thread Thierry Reding
On Mon, Dec 24, 2012 at 10:25:00PM -0700, Stephen Warren wrote: > On 12/21/2012 11:50 PM, Terje Bergström wrote: > > On 21.12.2012 16:36, Thierry Reding wrote: > >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > >>> +static struct platform_driver tegra_drm_platform_driver = { >

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-30 Thread Terje Bergström
On 28.12.2012 23:21, Thierry Reding wrote: > Instead of going over this back and forth, I've decided to rewrite this > patch from scratch the way I think it should be done. Maybe that'll make > things clearer. I haven't tested it on real hardware yet because I don't > have access over the holidays,

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2013-01-03 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) >> +{ >> + >> +} >> + > > This can be removed, right? Yes, done. > >> +static struct platform_driver tegra

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Thierry Reding
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen [...] > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c [...] > +static int tegra_drm_add_client(struct device *dev, void *data) > +{ > + static const char * const compat[] = { > +

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static struct platform_driver tegra_drm_platform_driver = { >> +.driver = { >> +.name = "tegradrm", > > This should be "tegra-drm" to match the module name. We've actu

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-24 Thread Stephen Warren
On 12/21/2012 11:50 PM, Terje Bergström wrote: > On 21.12.2012 16:36, Thierry Reding wrote: >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >>> +static struct platform_driver tegra_drm_platform_driver = { >>> + .driver = { >>> + .name = "tegradrm", >> >> This should

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-28 Thread Thierry Reding
On Mon, Dec 24, 2012 at 10:25:00PM -0700, Stephen Warren wrote: > On 12/21/2012 11:50 PM, Terje Bergström wrote: > > On 21.12.2012 16:36, Thierry Reding wrote: > >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > >>> +static struct platform_driver tegra_drm_platform_driver = { >

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-30 Thread Terje Bergström
On 28.12.2012 23:21, Thierry Reding wrote: > Instead of going over this back and forth, I've decided to rewrite this > patch from scratch the way I think it should be done. Maybe that'll make > things clearer. I haven't tested it on real hardware yet because I don't > have access over the holidays,

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2013-01-03 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) >> +{ >> + >> +} >> + > > This can be removed, right? Yes, done. > >> +static struct platform_driver tegra

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Thierry Reding
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen [...] > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c [...] > +static int tegra_drm_add_client(struct device *dev, void *data) > +{ > + static const char * const compat[] = { > +

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static struct platform_driver tegra_drm_platform_driver = { >> +.driver = { >> +.name = "tegradrm", > > This should be "tegra-drm" to match the module name. We've actu

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-24 Thread Stephen Warren
On 12/21/2012 11:50 PM, Terje Bergström wrote: > On 21.12.2012 16:36, Thierry Reding wrote: >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >>> +static struct platform_driver tegra_drm_platform_driver = { >>> + .driver = { >>> + .name = "tegradrm", >> >> This should

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-28 Thread Thierry Reding
On Mon, Dec 24, 2012 at 10:25:00PM -0700, Stephen Warren wrote: > On 12/21/2012 11:50 PM, Terje Bergström wrote: > > On 21.12.2012 16:36, Thierry Reding wrote: > >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > >>> +static struct platform_driver tegra_drm_platform_driver = { >

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-30 Thread Terje Bergström
On 28.12.2012 23:21, Thierry Reding wrote: > Instead of going over this back and forth, I've decided to rewrite this > patch from scratch the way I think it should be done. Maybe that'll make > things clearer. I haven't tested it on real hardware yet because I don't > have access over the holidays,

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2013-01-03 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) >> +{ >> + >> +} >> + > > This can be removed, right? Yes, done. > >> +static struct platform_driver tegra

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Thierry Reding
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen [...] > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c [...] > +static int tegra_drm_add_client(struct device *dev, void *data) > +{ > + static const char * const compat[] = { > +

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static struct platform_driver tegra_drm_platform_driver = { >> +.driver = { >> +.name = "tegradrm", > > This should be "tegra-drm" to match the module name. We've actu

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-24 Thread Stephen Warren
On 12/21/2012 11:50 PM, Terje Bergström wrote: > On 21.12.2012 16:36, Thierry Reding wrote: >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >>> +static struct platform_driver tegra_drm_platform_driver = { >>> + .driver = { >>> + .name = "tegradrm", >> >> This should

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-28 Thread Thierry Reding
On Mon, Dec 24, 2012 at 10:25:00PM -0700, Stephen Warren wrote: > On 12/21/2012 11:50 PM, Terje Bergström wrote: > > On 21.12.2012 16:36, Thierry Reding wrote: > >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > >>> +static struct platform_driver tegra_drm_platform_driver = { >

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-30 Thread Terje Bergström
On 28.12.2012 23:21, Thierry Reding wrote: > Instead of going over this back and forth, I've decided to rewrite this > patch from scratch the way I think it should be done. Maybe that'll make > things clearer. I haven't tested it on real hardware yet because I don't > have access over the holidays,

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2013-01-03 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) >> +{ >> + >> +} >> + > > This can be removed, right? Yes, done. > >> +static struct platform_driver tegra

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Thierry Reding
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > From: Arto Merilainen [...] > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c [...] > +static int tegra_drm_add_client(struct device *dev, void *data) > +{ > + static const char * const compat[] = { > +

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-21 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static struct platform_driver tegra_drm_platform_driver = { >> +.driver = { >> +.name = "tegradrm", > > This should be "tegra-drm" to match the module name. We've actu

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-24 Thread Stephen Warren
On 12/21/2012 11:50 PM, Terje Bergström wrote: > On 21.12.2012 16:36, Thierry Reding wrote: >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >>> +static struct platform_driver tegra_drm_platform_driver = { >>> + .driver = { >>> + .name = "tegradrm", >> >> This should

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-28 Thread Thierry Reding
On Mon, Dec 24, 2012 at 10:25:00PM -0700, Stephen Warren wrote: > On 12/21/2012 11:50 PM, Terje Bergström wrote: > > On 21.12.2012 16:36, Thierry Reding wrote: > >> On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: > >>> +static struct platform_driver tegra_drm_platform_driver = { >

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2012-12-30 Thread Terje Bergström
On 28.12.2012 23:21, Thierry Reding wrote: > Instead of going over this back and forth, I've decided to rewrite this > patch from scratch the way I think it should be done. Maybe that'll make > things clearer. I haven't tested it on real hardware yet because I don't > have access over the holidays,

Re: [PATCHv4 5/8] drm: tegra: Remove redundant host1x

2013-01-03 Thread Terje Bergström
On 21.12.2012 16:36, Thierry Reding wrote: > On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote: >> +static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) >> +{ >> + >> +} >> + > > This can be removed, right? Yes, done. > >> +static struct platform_driver tegra