Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Laurent Pinchart
Hi Hans, On Wed, Apr 05, 2023 at 10:50:37AM +0200, Hans Verkuil wrote: > On 05/04/2023 10:31, Luca Ceresoli wrote: > > On Wed, 5 Apr 2023 05:30:48 +0300 Laurent Pinchart wrote: > >> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: > >>> On Wed, 29 Mar 2023 13:16:22 +0200 Hans

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Thierry Reding
On Wed, Apr 05, 2023 at 10:50:37AM +0200, Hans Verkuil wrote: [...] > Note that this driver will stay in staging since it still fails when I try to > capture from two sensors at the same time: syncpoint errors start appearing > in that case. I think there are locking issues. I think I have someone

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Hans Verkuil
On 05/04/2023 10:31, Luca Ceresoli wrote: > Hi Laurent, > > On Wed, 5 Apr 2023 05:30:48 +0300 > Laurent Pinchart wrote: > >> Hi Luca, >> >> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: >>> On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil wrote: >>> Hi Luca, I

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Luca Ceresoli
Hi Laurent, On Wed, 5 Apr 2023 05:30:48 +0300 Laurent Pinchart wrote: > Hi Luca, > > On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: > > On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil wrote: > > > > > Hi Luca, > > > > > > I finally found the time to test this series. It

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-04 Thread Laurent Pinchart
Hi Luca, On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: > On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil wrote: > > > Hi Luca, > > > > I finally found the time to test this series. It looks OK, except for this > > patch. > > Thank you very much for taking the time! > > > The

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-04 Thread Luca Ceresoli
Hello Hans, On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil wrote: > Hi Luca, > > I finally found the time to test this series. It looks OK, except for this > patch. Thank you very much for taking the time! > The list of supported formats really has to be the intersection of what the >

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, On 29/03/2023 13:16, Hans Verkuil wrote: > Hi Luca, > > I finally found the time to test this series. It looks OK, except for this > patch. > The list of supported formats really has to be the intersection of what the > tegra > supports and what the sensor supports. > > Otherwise you

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, I finally found the time to test this series. It looks OK, except for this patch. The list of supported formats really has to be the intersection of what the tegra supports and what the sensor supports. Otherwise you would advertise pixelformats that cannot be used, and the

[RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-09 Thread Luca Ceresoli
The .vidioc_enum_fmt_vid_cap (called tegra_channel_enum_format() here) should return all the supported formats. Instead the current implementation computes the intersection between the formats it supports and those supported by the first subdev in the stream (typically the image sensor). Remove