Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-12 Thread Alexandru-Cosmin Gheorghe
On Fri, Mar 09, 2018 at 12:06:09PM +0100, Robert Foss wrote: > Hey, > > > On 03/09/2018 10:55 AM, Alexandru-Cosmin Gheorghe wrote: > >Hi Daniel, > > > >On Fri, Mar 09, 2018 at 09:29:24AM +, Daniel Stone wrote: > >>Hi John, > >> > >>On 8 March 2018 at 19:43, John Stultz wrote: > >>>On Thu, Ma

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-09 Thread Robert Foss
Hey, On 03/09/2018 10:55 AM, Alexandru-Cosmin Gheorghe wrote: Hi Daniel, On Fri, Mar 09, 2018 at 09:29:24AM +, Daniel Stone wrote: Hi John, On 8 March 2018 at 19:43, John Stultz wrote: On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss wrote: @@ -76,8 +76,6 @@ uint32_t DrmGenericImporter::C

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-09 Thread Alexandru-Cosmin Gheorghe
Hi Daniel, On Fri, Mar 09, 2018 at 09:29:24AM +, Daniel Stone wrote: > Hi John, > > On 8 March 2018 at 19:43, John Stultz wrote: > > On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss > > wrote: > >>> @@ -76,8 +76,6 @@ uint32_t > >>> DrmGenericImporter::ConvertHalFormatToDrm(uint32_t hal_format)

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-09 Thread Daniel Stone
Hi John, On 8 March 2018 at 19:43, John Stultz wrote: > On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss wrote: >>> @@ -76,8 +76,6 @@ uint32_t >>> DrmGenericImporter::ConvertHalFormatToDrm(uint32_t hal_format) { >>> return DRM_FORMAT_ABGR; >>> case HAL_PIXEL_FORMAT_RGB_565: >>>

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-09 Thread Alexandru-Cosmin Gheorghe
On Thu, Mar 08, 2018 at 11:43:25AM -0800, John Stultz wrote: > On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss wrote: > > Hey John, > > > > > > On 03/07/2018 12:19 AM, John Stultz wrote: > >> > >> As suggested by Alexandru-Cosmin Gheorghe: > >> > >> ConvertHALFormatToDrm logic would work only for 1 pl

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-08 Thread John Stultz
On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss wrote: > Hey John, > > > On 03/07/2018 12:19 AM, John Stultz wrote: >> >> As suggested by Alexandru-Cosmin Gheorghe: >> >> ConvertHALFormatToDrm logic would work only for 1 plane formats, >> and probably gets rejected by drmModeAddFb2, but to save >> deb

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-08 Thread Robert Foss
Hey John, On 03/07/2018 12:19 AM, John Stultz wrote: As suggested by Alexandru-Cosmin Gheorghe: ConvertHALFormatToDrm logic would work only for 1 plane formats, and probably gets rejected by drmModeAddFb2, but to save debugging time maybe it worth removing DRM_FORMAT_YVU420 from ConvertHALForm

[RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-06 Thread John Stultz
As suggested by Alexandru-Cosmin Gheorghe: ConvertHALFormatToDrm logic would work only for 1 plane formats, and probably gets rejected by drmModeAddFb2, but to save debugging time maybe it worth removing DRM_FORMAT_YVU420 from ConvertHALFormatToDrm and checking it's return code. So this patch tr