[RFC] drm: Add utility function to check for edp1.4

2014-11-04 Thread sonika
On Monday 03 November 2014 01:58 PM, Daniel Vetter wrote: > On Mon, Nov 3, 2014 at 9:25 AM, Thierry Reding wrote: >>> The idea is that you'd grab the DPCD field anyway since it's needed all >>> over the place. We have a pile of helpers already that take exactly this >>> block and decode parts of

[RFC] drm: Add utility function to check for edp1.4

2014-11-03 Thread Daniel Vetter
On Mon, Nov 3, 2014 at 9:25 AM, Thierry Reding wrote: >> The idea is that you'd grab the DPCD field anyway since it's needed all >> over the place. We have a pile of helpers already that take exactly this >> block and decode parts of it. So I think this makes sense - dp aux is fast >> but not enti

[RFC] drm: Add utility function to check for edp1.4

2014-11-03 Thread Thierry Reding
On Fri, Oct 31, 2014 at 05:06:39PM +0100, Daniel Vetter wrote: > On Wed, Oct 29, 2014 at 02:42:29PM +0100, Thierry Reding wrote: > > On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jindal at intel.com wrote: > > > From: Sonika Jindal > > > > > > v2: Reading DP_EDP_REV, only when DISPLAY_CONTROL_

[RFC] drm: Add utility function to check for edp1.4

2014-10-31 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 02:42:29PM +0100, Thierry Reding wrote: > On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jindal at intel.com wrote: > > From: Sonika Jindal > > > > v2: Reading DP_EDP_REV, only when DISPLAY_CONTROL_CAPABLE field is set > > (Satheesh) > > > > v3: Moving the utility func

[RFC] drm: Add utility function to check for edp1.4

2014-10-30 Thread sonika
Thanks for your comments Thierry. I agree to all your comments. I will write a general function to return version and repost the patch Thanks, Sonika On Wednesday 29 October 2014 07:12 PM, Thierry Reding wrote: > On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jindal at intel.com wrote: >> From:

[RFC] drm: Add utility function to check for edp1.4

2014-10-29 Thread Thierry Reding
On Wed, Oct 22, 2014 at 11:45:23AM +0530, sonika.jindal at intel.com wrote: > From: Sonika Jindal > > v2: Reading DP_EDP_REV, only when DISPLAY_CONTROL_CAPABLE field is set > (Satheesh) > > v3: Moving the utility function to drm_dp_helper (Daniel) > > Signed-off-by: Sonika Jindal > --- > dri

[RFC] drm: Add utility function to check for edp1.4

2014-10-22 Thread sonika.jin...@intel.com
From: Sonika Jindal v2: Reading DP_EDP_REV, only when DISPLAY_CONTROL_CAPABLE field is set (Satheesh) v3: Moving the utility function to drm_dp_helper (Daniel) Signed-off-by: Sonika Jindal --- drivers/gpu/drm/drm_dp_helper.c | 15 +++ include/drm/drm_dp_helper.h |2 ++