Re: [RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-09 Thread Dmitry Baryshkov
On 08/03/2023 22:02, Abhinav Kumar wrote: For DRM property blobs created by user mode using drm_property_create_blob(), if the blob value needs to be updated the only way is to destroy the previous blob and create a new one instead. For some of the property blobs, if the size of the blob is

Re: [RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-08 Thread Abhinav Kumar
Hi Ville Thanks for the comments. On 3/8/2023 4:10 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2023 at 03:33:48PM -0800, Rob Clark wrote: On Wed, Mar 8, 2023 at 1:23 PM Ville Syrjälä wrote: On Wed, Mar 08, 2023 at 12:02:42PM -0800, Abhinav Kumar wrote: For DRM property blobs created by user

Re: [RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2023 at 03:33:48PM -0800, Rob Clark wrote: > On Wed, Mar 8, 2023 at 1:23 PM Ville Syrjälä > wrote: > > > > On Wed, Mar 08, 2023 at 12:02:42PM -0800, Abhinav Kumar wrote: > > > For DRM property blobs created by user mode using > > > drm_property_create_blob(), if the blob value

Re: [RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-08 Thread Rob Clark
On Wed, Mar 8, 2023 at 1:23 PM Ville Syrjälä wrote: > > On Wed, Mar 08, 2023 at 12:02:42PM -0800, Abhinav Kumar wrote: > > For DRM property blobs created by user mode using > > drm_property_create_blob(), if the blob value needs to be updated the > > only way is to destroy the previous blob and

Re: [RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2023 at 12:02:42PM -0800, Abhinav Kumar wrote: > For DRM property blobs created by user mode using > drm_property_create_blob(), if the blob value needs to be updated the > only way is to destroy the previous blob and create a new one instead. > > For some of the property blobs,

[RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-08 Thread Abhinav Kumar
For DRM property blobs created by user mode using drm_property_create_blob(), if the blob value needs to be updated the only way is to destroy the previous blob and create a new one instead. For some of the property blobs, if the size of the blob is more than one page size, kvzalloc() can slow