Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 11:46:26AM +, Emil Velikov wrote: > On Tue, 11 Feb 2020 at 08:06, Pekka Paalanen wrote: > > > > On Mon, 10 Feb 2020 19:01:06 + > > Emil Velikov wrote: > > > > > Thanks for having a look Daniel. > > > > > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > >

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Emil Velikov
On Mon, 10 Feb 2020 at 21:54, Daniel Vetter wrote: > > On Mon, Feb 10, 2020 at 8:01 PM Emil Velikov wrote: > > > > Thanks for having a look Daniel. > > > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > > From: Em

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Emil Velikov
On Tue, 11 Feb 2020 at 08:06, Pekka Paalanen wrote: > > On Mon, 10 Feb 2020 19:01:06 + > Emil Velikov wrote: > > > Thanks for having a look Daniel. > > > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > > From

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Pekka Paalanen
On Mon, 10 Feb 2020 19:01:06 + Emil Velikov wrote: > Thanks for having a look Daniel. > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > This commit reworks the permission handli

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-10 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 8:01 PM Emil Velikov wrote: > > Thanks for having a look Daniel. > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > This commit reworks the permission handling of

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-10 Thread Emil Velikov
Thanks for having a look Daniel. On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > From: Emil Velikov > > > > This commit reworks the permission handling of the two ioctls. In > > particular it enforced the CAP_SYS_ADMIN check

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-07 Thread Daniel Vetter
On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > From: Emil Velikov > > This commit reworks the permission handling of the two ioctls. In > particular it enforced the CAP_SYS_ADMIN check only, if: > - we're issuing the ioctl from process other than the one which opened > the node,

[RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-05 Thread Emil Velikov
From: Emil Velikov This commit reworks the permission handling of the two ioctls. In particular it enforced the CAP_SYS_ADMIN check only, if: - we're issuing the ioctl from process other than the one which opened the node, and - we are, or were master in the past This allows for any applicatio