Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-24 Thread Sam Ravnborg
Hi Boris. > > > > Both devices are supported today by the atmel_lcdfb driver. > > For this new set of drivers the compatible strings was > > selected to avoid clash with the existing compatible > > strings used for the atmel_lcdfb driver to allow them > > to co-exist. > > Hm, I think Rob

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-24 Thread Boris Brezillon
Hi Sam, On Sun, 12 Aug 2018 20:41:52 +0200 Sam Ravnborg wrote: > New DRM based driver for at91sam9 SOC's that uses the > Atmel LCDC IP core. First of all, thanks for this contribution. > > This is first version of a patch set that adds > drivers for the Atmel LCDC IP core. > Posted for

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-23 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 10:12 PM, Sam Ravnborg wrote: > Hi Daniel. > >> > > Based on the above, would it be possible to utilise some >> > > of these features without any dedicated userspace (mesa) support? >> > > Any other driver that has something similar that can be used >> > > for inspiration?

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-22 Thread Sam Ravnborg
Hi Daniel. > > > Based on the above, would it be possible to utilise some > > > of these features without any dedicated userspace (mesa) support? > > > Any other driver that has something similar that can be used > > > for inspiration? > > > > This is really an interesting question indeed. > >

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-16 Thread Sam Ravnborg
Hi Peter. > > I stopped pushing that patch for reasons mentioned in > https://lkml.org/lkml/2018/4/9/108 > > However, since then, the component approach mentioned in that mail was > shot down and instead the tda998x driver is now a bridge (or soon, I expect > the series from Russell King that

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-16 Thread Peter Rosin
On 2018-08-15 17:04, Daniel Vetter wrote: > On Wed, Aug 15, 2018 at 4:45 PM, Rob Herring wrote: >> On Tue, Aug 14, 2018 at 10:48 PM Sam Ravnborg wrote: >>> >> >> [...] >> > One DT related Q: > The LCD Controller supports BGR565, but as this is less common some HW > implmentations

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Daniel Vetter
On Wed, Aug 15, 2018 at 4:45 PM, Rob Herring wrote: > On Tue, Aug 14, 2018 at 10:48 PM Sam Ravnborg wrote: >> > > [...] > >> > > One DT related Q: >> > > The LCD Controller supports BGR565, but as this is less common some HW >> > > implmentations >> > > exchange R and B, expessed in the old

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Rob Herring
On Tue, Aug 14, 2018 at 10:48 PM Sam Ravnborg wrote: > [...] > > > One DT related Q: > > > The LCD Controller supports BGR565, but as this is less common some HW > > > implmentations > > > exchange R and B, expessed in the old binding as wiring-mode like this: > > > > > >

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Sam Ravnborg
Hi Rob. > I don't know that 2 registers for a backlight PWM constitute an MFD. A > single node can be both an LCD controller and a PWM. Current suggestion from v1 patchset looks like this: lcdc0: lcdc@70 { compatible = "atmel,at91sam9263-lcdc-mfd";

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Alexandre Belloni
On 13/08/2018 20:18:08+0200, Sam Ravnborg wrote: > > Would be good to have a plan to phase-out the old atmel_lcdfb fbdev > > driver when this one addresses some TODO items that make sense. > Agree on this. > One approach could be to say that when all in-kernel users of atmel_lcdfb > are ported,

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Sam Ravnborg
Hi Rob. Thanks for the feedback, as I am rather new to this DT stuff a few iterations are no suprise. > > If I understand the proposal from you correct an example binding would > > look like this: > > > >lcdc0: lcdc@70 { > > compatible = "atmel,at91sam9263-lcdc"; > >

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-15 Thread Sam Ravnborg
On Tue, Aug 14, 2018 at 04:36:03PM +0200, Alexandre Belloni wrote: > On 13/08/2018 20:18:08+0200, Sam Ravnborg wrote: > > > Would be good to have a plan to phase-out the old atmel_lcdfb fbdev > > > driver when this one addresses some TODO items that make sense. > > Agree on this. > > One approach

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Rob Herring
On Tue, Aug 14, 2018 at 06:43:43PM +0200, Sam Ravnborg wrote: > Hi Rob. > > > I don't know that 2 registers for a backlight PWM constitute an MFD. A > > single node can be both an LCD controller and a PWM. > > Current suggestion from v1 patchset looks like this: > lcdc0: lcdc@70 { >

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Daniel Vetter
On Mon, Aug 13, 2018 at 04:47:26PM +0200, Nicolas Ferre wrote: > On 12/08/2018 at 21:55, Sam Ravnborg wrote: > > The at91sam9263 has a few interesting "GPU" features: > > > > - 2D memory addressing > >Data sheet says: > > The LCDC can be configured to work on a frame buffer > > larger

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Sam Ravnborg
Hi Nicholas. On Mon, Aug 13, 2018 at 05:54:48PM +0200, Nicolas Ferre wrote: > On 12/08/2018 at 20:41, Sam Ravnborg wrote: > >New DRM based driver for at91sam9 SOC's that uses the > >Atmel LCDC IP core. > > I'm delighted to see this work: Thanks a lot Sam! Glad to hear. I was a bit worried that

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Nicolas Ferre
On 12/08/2018 at 21:55, Sam Ravnborg wrote: The at91sam9263 has a few interesting "GPU" features: - 2D memory addressing Data sheet says: The LCDC can be configured to work on a frame buffer larger than the actual screen size. By changing the values in a few

[RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Sam Ravnborg
New DRM based driver for at91sam9 SOC's that uses the Atmel LCDC IP core. This is first version of a patch set that adds drivers for the Atmel LCDC IP core. Posted for review as the basics works now. The LCDC IP core contains two devices: - a PWM often used for backlight - a LCD display

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Nicolas Ferre
On 12/08/2018 at 20:41, Sam Ravnborg wrote: New DRM based driver for at91sam9 SOC's that uses the Atmel LCDC IP core. I'm delighted to see this work: Thanks a lot Sam! This is first version of a patch set that adds drivers for the Atmel LCDC IP core. Posted for review as the basics works

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-14 Thread Sam Ravnborg
The at91sam9263 has a few interesting "GPU" features: - 2D memory addressing Data sheet says: The LCDC can be configured to work on a frame buffer larger than the actual screen size. By changing the values in a few registers, it is easy to move the displayed area

Re: [RFC PATCH 0/7] add at91sam9 LCDC DRM driver

2018-08-13 Thread Rob Herring
On Mon, Aug 13, 2018 at 08:18:08PM +0200, Sam Ravnborg wrote: > Hi Nicholas. > > On Mon, Aug 13, 2018 at 05:54:48PM +0200, Nicolas Ferre wrote: > > On 12/08/2018 at 20:41, Sam Ravnborg wrote: > > >New DRM based driver for at91sam9 SOC's that uses the > > >Atmel LCDC IP core. > > > > I'm