Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-16 Thread Deepak Rawat
> > > > > > Hi Thomas, > > > > > > I am working on adding gen2 VM support and cursor support. Also > > > for my > > > next interation moving the driver out of tiny. Progress is slow > > > lately > > > as busy with other stuff at work. Hopefully I will be able to > > > finish > > > during coming

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-16 Thread Daniel Vetter
On Sun, Nov 15, 2020 at 07:58:00PM +0100, Thomas Zimmermann wrote: > Hi > > Am 15.11.20 um 18:55 schrieb Deepak Rawat: > > On Sun, 2020-11-15 at 10:14 +0100, Thomas Zimmermann wrote: > >> Hi Deepak > >> > >> Am 11.09.20 um 02:38 schrieb Deepak Rawat: > >>> On Thu, 2020-09-10 at 08:19 +, Tang,

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-15 Thread Thomas Zimmermann
Hi Am 15.11.20 um 18:55 schrieb Deepak Rawat: > On Sun, 2020-11-15 at 10:14 +0100, Thomas Zimmermann wrote: >> Hi Deepak >> >> Am 11.09.20 um 02:38 schrieb Deepak Rawat: >>> On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: Hi Deepak,   Do you have a new version of this patch

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-15 Thread Deepak Rawat
On Sun, 2020-11-15 at 10:14 +0100, Thomas Zimmermann wrote: > Hi Deepak > > Am 11.09.20 um 02:38 schrieb Deepak Rawat: > > On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: > > > Hi Deepak, > > >   > > > Do you have a new version of this patch now? > > > I take a try with it. and meet some

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-11-15 Thread Thomas Zimmermann
Hi Deepak Am 11.09.20 um 02:38 schrieb Deepak Rawat: > On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: >> Hi Deepak, >> >> Do you have a new version of this patch now? >> I take a try with it. and meet some typo and “incompatible pointer” >> error. >> If you have a new version, could yo

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-29 Thread Marcin Skarbek
Hi Deepak, I have tested your patch using Fedora 32 as a guest and Windows 10 Pro 1809 as host (Gen 2 VM). No issues with building or loading the kernel module and I have successfully run SwayWM inside VM using hyperv_drm. Unfortunately, I'm unable to change the resolution beyond FHD. I have a WQH

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-10 Thread Deepak Rawat
On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: > Hi Deepak, > > Do you have a new version of this patch now? > I take a try with it. and meet some typo and “incompatible pointer” > error. > If you have a new version, could you share it with us? > Hi Shaofeng, It seems you are running

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-10 Thread Tang, Shaofeng
Hi Deepak, Do you have a new version of this patch now? I take a try with it. and meet some typo and "incompatible pointer" error. If you have a new version, could you share it with us? BR, Shaofeng ___ dri-devel mailing list dri-devel@lists.freedesktop

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-24 Thread Deepak Rawat
> > > Thanks for the review. Unfortunately only the first vmbus message > > > take > > > effect and subsequent calls are ignored. I originally implemented > > > using > > > vram helpers but I figured out calling this vmbus message again > > > won't > > > change the vram location. > > /me notices

RE: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-24 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Deepak Rawat > Sent: Monday, June 22, 2020 11:49 PM > > [...] > > Some quick comments: > > 1. hyperv_vmbus_probe() assumes the existence of the PCI device, > > which > > is not true in a Hyper-V Generation-2 VM. > > I guess that mean for G

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Gerd Hoffmann
Hi, > > > > + msg->vram.user_ctx = msg->vram.vram_gpa = vram_pp; > > > > + msg->vram.is_vram_gpa_specified = 1; > > > > + synthvid_send(hdev, msg); > > > > > > That suggests it is possible to define multiple framebuffers in vram, > > > then pageflip by setting vram.vram_gpa.

RE: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Deepak Rawat > Sent: Monday, June 22, 2020 4:06 AM > > DRM driver for hyperv synthetic video device, based on hyperv_fb > framebuffer driver. Also added config option "DRM_HYPERV" to enabled > this driver. Hi Deepak, I had a quick look an

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Daniel Vetter
On Mon, Jun 22, 2020 at 03:20:34PM -0700, Deepak Rawat wrote: > On Mon, 2020-06-22 at 14:46 +0200, Gerd Hoffmann wrote: > > Hi, > > > > > +/* Should be done only once during init and resume */ > > > +static int synthvid_update_vram_location(struct hv_device *hdev, > > > +

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Thomas Zimmermann
Hi Am 23.06.20 um 11:12 schrieb Deepak Rawat: > On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: >> Hi Deepak >> >> I did not receive you pat series, so I can only comment on Sam's >> reply. >> See below for some points. > > Hi Thomas, Thanks for the review. I wanted to add you in cc l

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Deepak Rawat
On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: > Hi Deepak > > I did not receive you pat series, so I can only comment on Sam's > reply. > See below for some points. Hi Thomas, Thanks for the review. I wanted to add you in cc list but messed it up with final git send-email. Sorry abo

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-23 Thread Thomas Zimmermann
Hi Deepak I did not receive you pat series, so I can only comment on Sam's reply. See below for some points. Am 22.06.20 um 17:19 schrieb Sam Ravnborg: > Hi Deepak > > On Mon, Jun 22, 2020 at 04:06:22AM -0700, Deepak Rawat wrote: >> DRM driver for hyperv synthetic video device, based on hyperv_f

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
On Tue, 2020-06-23 at 02:31 +, Dexuan Cui wrote: > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Deepak Rawat > > Sent: Monday, June 22, 2020 4:06 AM > > > > DRM driver for hyperv synthetic video device, based on hyperv_fb > > framebuffer driver. Also added config option "DRM_HY

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
> > Just a buch of drive-by comments while browsing the code. > In general code looks good, especialyl for a v1. > > There is a few places that triggers warnings with checkpatch --strict > Most looks like things that should be fixed. > > Thanks Sam for the review. Will take care of the sugge

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
On Mon, 2020-06-22 at 14:46 +0200, Gerd Hoffmann wrote: > Hi, > > > +/* Should be done only once during init and resume */ > > +static int synthvid_update_vram_location(struct hv_device *hdev, > > + phys_addr_t vram_pp) > > +{ > > + struct hyperv_device *hv

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Sam Ravnborg
Hi Deepak On Mon, Jun 22, 2020 at 04:06:22AM -0700, Deepak Rawat wrote: > DRM driver for hyperv synthetic video device, based on hyperv_fb > framebuffer driver. Also added config option "DRM_HYPERV" to enabled > this driver. Just a buch of drive-by comments while browsing the code. In general cod

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Gerd Hoffmann
Hi, > +/* Should be done only once during init and resume */ > +static int synthvid_update_vram_location(struct hv_device *hdev, > + phys_addr_t vram_pp) > +{ > + struct hyperv_device *hv = hv_get_drvdata(hdev); > + struct synthvid_msg *msg = (struct

[RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-06-22 Thread Deepak Rawat
DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/tiny/Kconfig |9 + drivers/gpu/drm/tiny/Makefile |1 + drivers/gpu/drm/tiny/hyperv_d