Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-13 Thread Abhinav Kumar
On 1/11/2023 2:21 PM, Marijn Suijten wrote: On 2023-01-11 17:11:03, Dmitry Baryshkov wrote: On 11/01/2023 10:44, Marijn Suijten wrote: On 2023-01-09 12:32:18, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: +struct msm_mdss_data { +    u32 ubwc_version; +    u32 ubwc_

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-11 Thread Marijn Suijten
On 2023-01-11 17:11:03, Dmitry Baryshkov wrote: > On 11/01/2023 10:44, Marijn Suijten wrote: > > On 2023-01-09 12:32:18, Abhinav Kumar wrote: > > > On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: > > > > +struct msm_mdss_data { > > +    u32 ubwc_version; > > +    u32 ubwc_swizzle;

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-11 Thread Dmitry Baryshkov
On 11/01/2023 10:44, Marijn Suijten wrote: On 2023-01-09 12:32:18, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: +struct msm_mdss_data { +    u32 ubwc_version; +    u32 ubwc_swizzle; +    u32 ubwc_static; +    u32 highest_bank_bit; +    u32 macrotile_mode; +}; This mag

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-11 Thread Marijn Suijten
On 2023-01-09 12:32:18, Abhinav Kumar wrote: > >> On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: > >>> +struct msm_mdss_data { > >>> +    u32 ubwc_version; > >>> +    u32 ubwc_swizzle; > >>> +    u32 ubwc_static; > >>> +    u32 highest_bank_bit; > >>> +    u32 macrotile_mode; > >>> +}; This magic

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-09 Thread Abhinav Kumar
On 1/9/2023 1:11 PM, Dmitry Baryshkov wrote: On 09/01/2023 22:32, Abhinav Kumar wrote: On 1/9/2023 12:17 PM, Dmitry Baryshkov wrote: On 09/01/2023 21:53, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: To simplify adding new platforms and to make settings more obviou

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-09 Thread Dmitry Baryshkov
On 09/01/2023 22:32, Abhinav Kumar wrote: On 1/9/2023 12:17 PM, Dmitry Baryshkov wrote: On 09/01/2023 21:53, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structu

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-09 Thread Abhinav Kumar
On 1/9/2023 12:17 PM, Dmitry Baryshkov wrote: On 09/01/2023 21:53, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structure to pass platform config rather than jus

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-09 Thread Dmitry Baryshkov
On 09/01/2023 21:53, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structure to pass platform config rather than just calling the functions direcly. Why not use the

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-09 Thread Abhinav Kumar
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structure to pass platform config rather than just calling the functions direcly. Why not use the catalog to store this information rather

[RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2022-12-07 Thread Dmitry Baryshkov
To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structure to pass platform config rather than just calling the functions direcly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 158 -